fix(desktop): manual tool previews via status stack - #51103
Merged
Merged
Conversation
🔎 Lint report:
|
| Rule | Count |
|---|---|
invalid-assignment |
1 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`
✅ Fixed issues (2):
| Rule | Count |
|---|---|
unresolved-attribute |
2 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
run_agent.py:2984: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
Unchanged: 6051 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
Drop gateway-event preview registration so HTML artifacts from tool results no longer pop the rail. De-dupe the inline preview card label.
OutThisLife
force-pushed
the
bb/desktop-tool-preview-cleanup
branch
from
June 23, 2026 00:21
071e0e8 to
6f56c9e
Compare
Register previewable artifacts from the tool row, feed a session-scoped store, and render compact rows above the composer. Remove the inline preview card.
Status row opens/closes the preview pane; external link uses a dedicated file:// browser bridge (openExternal, not openPath).
Drop the inline-code border; halve the expanded tool block radius.
OutThisLife
force-pushed
the
bb/desktop-tool-preview-cleanup
branch
from
June 23, 2026 00:23
6f56c9e to
7daa6d8
Compare
OutThisLife
enabled auto-merge
June 23, 2026 00:24
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ol-preview-cleanup fix(desktop): manual tool previews via status stack
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…ol-preview-cleanup fix(desktop): manual tool previews via status stack
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…ol-preview-cleanup fix(desktop): manual tool previews via status stack
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…ol-preview-cleanup fix(desktop): manual tool previews via status stack
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…ol-preview-cleanup fix(desktop): manual tool previews via status stack
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…ol-preview-cleanup fix(desktop): manual tool previews via status stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool.*events. Session-switch restore of a user-opened preview and refresh-when-already-open on file diffs are preserved.file://viashell.openExternal, notopenPath.previewTargetthe card used.codeborder; halve expanded tool block radius.Test plan
.html→ status stack shows preview row; rail does not auto-opendemo.htmlin prose has no border; expanded tool diff has tighter cornersvitest run apps/desktop/src/store/preview-status.test.ts apps/desktop/src/store/preview.test.ts apps/desktop/src/app/session/hooks/use-preview-routing.test.tsx