Skip to content

fix(desktop): manual tool previews via status stack - #51103

Merged
OutThisLife merged 4 commits into
mainfrom
bb/desktop-tool-preview-cleanup
Jun 23, 2026
Merged

OutThisLife merged 4 commits into
mainfrom
bb/desktop-tool-preview-cleanup

Conversation

@OutThisLife

@OutThisLife OutThisLife commented Jun 22, 2026 •

Copy link
Copy Markdown

Summary

  • No auto-open. Tool results no longer push HTML/localhost artifacts into the right-rail preview on tool.* events. Session-switch restore of a user-opened preview and refresh-when-already-open on file diffs are preserved.
  • Status stack link. Detected preview artifacts surface as a single always-visible row in the composer status stack (not an inline card, not a collapsible group). Row toggles the preview rail open/closed; external-browser opens file:// via shell.openExternal, not openPath.
  • Removed inline preview card from tool rows; detection feeds the status stack from the same previewTarget the card used.
  • Polish: drop inline code border; halve expanded tool block radius.

Test plan

  • Agent writes/edits .html → status stack shows preview row; rail does not auto-open
  • Click row → rail opens; click again (Hide) → rail closes
  • External-browser button opens local HTML in the system browser
  • Dismiss (X) removes the row without affecting an open rail
  • Inline demo.html in prose has no border; expanded tool diff has tighter corners
  • vitest run apps/desktop/src/store/preview-status.test.ts apps/desktop/src/store/preview.test.ts apps/desktop/src/app/session/hooks/use-preview-routing.test.tsx

@github-actions

github-actions Bot commented Jun 22, 2026 •

Copy link
Copy Markdown

🔎 Lint report: bb/desktop-tool-preview-cleanup vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 11478 on HEAD, 11480 on base (✅ -2)

🆕 New issues (1):

Rule Count
invalid-assignment 1
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`

✅ Fixed issues (2):

Rule Count
unresolved-attribute 2
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
run_agent.py:2984: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`

Unchanged: 6051 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/tui Terminal UI (ui-tui/ + tui_gateway/) labels Jun 23, 2026
@OutThisLife OutThisLife changed the title fix(desktop): stop auto-opening tool previews; de-dupe preview card fix(desktop): manual tool previews via status stack Jun 23, 2026
Drop gateway-event preview registration so HTML artifacts from tool results
no longer pop the rail. De-dupe the inline preview card label.
@OutThisLife
OutThisLife force-pushed the bb/desktop-tool-preview-cleanup branch from 071e0e8 to 6f56c9e Compare June 23, 2026 00:21
Register previewable artifacts from the tool row, feed a session-scoped store,
and render compact rows above the composer. Remove the inline preview card.
Status row opens/closes the preview pane; external link uses a dedicated
file:// browser bridge (openExternal, not openPath).
Drop the inline-code border; halve the expanded tool block radius.
@OutThisLife
OutThisLife force-pushed the bb/desktop-tool-preview-cleanup branch from 6f56c9e to 7daa6d8 Compare June 23, 2026 00:23
@OutThisLife
OutThisLife enabled auto-merge June 23, 2026 00:24
@OutThisLife
OutThisLife merged commit 2a10b83 into main Jun 23, 2026
34 checks passed
@OutThisLife
OutThisLife deleted the bb/desktop-tool-preview-cleanup branch June 23, 2026 00:29
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
…ol-preview-cleanup

fix(desktop): manual tool previews via status stack
habarmc1223-sudo pushed a commit to habarmc1223-sudo/hermes-agent-fluxmem that referenced this pull request Jul 8, 2026
…ol-preview-cleanup

fix(desktop): manual tool previews via status stack
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
…ol-preview-cleanup

fix(desktop): manual tool previews via status stack
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
…ol-preview-cleanup

fix(desktop): manual tool previews via status stack
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
…ol-preview-cleanup

fix(desktop): manual tool previews via status stack
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
…ol-preview-cleanup

fix(desktop): manual tool previews via status stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tui Terminal UI (ui-tui/ + tui_gateway/) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants