fix(desktop): avoid stack overflow on embedded image replay - #51093
Merged
Merged
Conversation
Replace the giant embedded-image regex with a bounded scanner so opening sessions with multi-megabyte data URLs does not crash the renderer.
🔎 Lint report:
|
OutThisLife
enabled auto-merge
June 22, 2026 23:21
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ring-stack-overflow fix(desktop): avoid stack overflow on embedded image replay
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…ring-stack-overflow fix(desktop): avoid stack overflow on embedded image replay
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…ring-stack-overflow fix(desktop): avoid stack overflow on embedded image replay
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…ring-stack-overflow fix(desktop): avoid stack overflow on embedded image replay
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…ring-stack-overflow fix(desktop): avoid stack overflow on embedded image replay
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…ring-stack-overflow fix(desktop): avoid stack overflow on embedded image replay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data:image/...;base64,...payloads do not throwRangeError: Maximum call stack size exceededduring session replay.image_urlenvelope extraction behavior.Test plan
npm run test:ui -- src/lib/embedded-images.test.tsnpx eslint src/lib/embedded-images.ts src/lib/embedded-images.test.tsnpm run build