fix(cron): deliver max-iteration fallback reports - #50980
Closed
helix4u wants to merge 1 commit into
Closed
Conversation
helix4u
marked this pull request as ready for review
June 22, 2026 18:51
19 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the cron-specific path where an agent reaches the iteration limit, produces a usable max-iteration fallback report, and then cron raises that report text as a runtime error because the generic agent result has
completed=False.The generic agent/finalizer semantics stay unchanged: max-iteration turns are still incomplete for interactive and worker paths. Cron now treats a non-empty
max_iterations_reached(...)fallback response as deliverable output instead of turning the response intoRuntimeError(<full report>).This matches the support log shape from the thread:
Turn ended: reason=max_iterations_reached(60/60) ... last_msg_role=assistant response_len=1707, immediately followed by cron raising the full generated price-check report.Related Issue
Discord support thread: https://discord.com/channels/1053877538025386074/1518634271122784427
Related but separate PRs:
text_response(...)boundary behavior, but this thread's fresh log showsmax_iterations_reached(60/60).Type of Change
Changes Made
cron/scheduler.py: allow cron to deliver a non-emptymax_iterations_reached(...)fallback response instead of raising it as an error whencompleted=False.tests/cron/test_scheduler.py: add regression coverage for the fresh support-log shape.How to Test
scripts/run_tests.sh -j 4 tests/cron/test_scheduler.pysuccess=Trueand include the report in cron output.failed=True, empty incomplete output, or explicit errors still fail.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A
Screenshots / Logs
Focused test run:
scripts/run_tests.sh -j 4 tests/cron/test_scheduler.pyResult: 163 tests passed.