fix(auth): write Anthropic OAuth token files atomically to prevent corruption - #5095
Closed
maymuneth wants to merge 1 commit into
Closed
fix(auth): write Anthropic OAuth token files atomically to prevent corruption#5095maymuneth wants to merge 1 commit into
maymuneth wants to merge 1 commit into
Conversation
This was referenced Apr 24, 2026
Contributor
|
Thanks for this fix, @maymuneth — the atomic write pattern you introduced has been merged into Evidence:
This is an automated hermes-sweeper review. Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
agent/anthropic_adapter.pywrites Anthropic OAuth token files usingwrite_text()directly — a non-atomic operation. If the process iskilled mid-write (crash, OOM, SIGKILL), the file is left partially
written and corrupt.
On the next startup,
json.loads()fails to parse the corrupt tokenfile — the user's Anthropic OAuth session is permanently broken and
they must re-authenticate manually.
Two write sites are affected:
_HERMES_OAUTH_FILE— the main Hermes OAuth token storecred_path— per-credential token filesFix
Write to a
.tmpsibling file first, then usePath.replace()whichis atomic on POSIX systems (rename syscall).
This is consistent with the atomic write pattern already used in
hermes_cli/auth.py(_save_auth_store),gateway/run.py, andtools/skill_manager_tool.py.Type of Change
Checklist