Repository navigation
fix(cron): allow profile-local cron storage - #50888
Closed
jeeves-assistant wants to merge 2 commits into
Closed
jeeves-assistant wants to merge 2 commits into
jeeves-assistant wants to merge 2 commits into
Conversation
Author
|
Closing as superseded by current main. The latest update includes #51116, which deliberately reverts the root-anchored cron store and returns cron job storage/lock paths to the active profile's HERMES_HOME. I verified current main resolves a profile HERMES_HOME to profile-local cron/jobs.json and .tick.lock, so this PR's opt-in cron.storage_scope approach is no longer needed and now conflicts with the chosen behavior. |
Author
|
Superseded by #51116 on current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cron.storage_scopewith defaultrootto preserve existing root-wide cron behavior.cron.storage_scope: profileso they read/write their ownprofiles/<name>/cron/jobs.jsoninstead of competing for the default profile's cron store.Why
Multiple resident profile gateways can otherwise all tick the default/root cron store. That makes isolated persona bots try to run default-profile jobs, miss their own profile-local jobs, and emit confusing delivery/auth failures.
Test Plan
python -m py_compile cron/jobs.py cron/scheduler.py hermes_cli/config.pypython -m pytest tests/cron/test_cron_profile_storage.py tests/cron/test_claim_job_for_fire.py -q -o 'addopts='python -m pytest tests/cron/test_cron_profile_storage.py tests/cron/test_claim_job_for_fire.py tests/cron/test_jobs.py -q -o 'addopts='python -m pytest tests/cron -q -o 'addopts='