fix(desktop): allow builds from non-git checkouts with fallback commit - #50864
Open
allin2 wants to merge 2 commits into
Open
fix(desktop): allow builds from non-git checkouts with fallback commit#50864allin2 wants to merge 2 commits into
allin2 wants to merge 2 commits into
Conversation
The desktop build script write-build-stamp.cjs threw a fatal error when the project source was not a git repository (e.g. downloaded as ZIP, deployed via bootstrap installer without .git). Added fromFallback() that provides a placeholder commit hash (0000000...) for non-git builds. The desktop app treats this as 'unknown' and skips commit-pinned first-launch bootstrap. Fixes NousResearch#50823
Contributor
|
Thanks for addressing the non-git desktop-build failure. The premise remains valid on current main: Problems
Suggested changes
Automated hermes-sweeper review. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The desktop build script threw a fatal error when the project source was not a git repository.
Motivation
Fixes #50823
Users who downloaded the source as a ZIP archive or deployed via bootstrap installer without a
.gitdirectory could not build the Windows desktop client.Changes
fromFallback()that provides a placeholder commit hash for non-git builds0000000...as 'unknown' and skips commit-pinned first-launch bootstrapValidation
Checklist