feat(delegation): add policy-bound profiles - #50720
Closed
marcusglee11 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Related: #4928 (feature request for named delegation capability profiles), #11169 / #34754 / #41998 (open competing implementations), #44412 (closed earlier attempt). This PR takes a distinct policy-bound mechanism (toolsets as an upper bound that per-call args may narrow but not widen, fail-closed validation, ACP-override conflict rejection, AA/Oracle review provenance) rather than the flexible override-with-fallback approach of the sibling PRs. Tracking as related so reviewers can compare mechanisms across the cluster — not marking duplicate. |
Contributor
|
This is the kanban |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a v1 of policy-bound delegation profiles for
delegate_task.profileto top-leveldelegate_taskand per-task batch entries.delegation.profilesconfig.profilecombined with per-callacp_command/acp_argsso raw task payloads cannot mutate trusted transport policy.Safety shape
Profiles are policy objects, not free per-call provider overrides:
toolsetsare an upper bound;toolsets: []means no toolsets rather than falling back;acp_args=[].Review provenance
AA/Oracle architecture review on the issue returned
AMEND: implement named policy-bound profiles rather than arbitrary per-call model/provider overrides.A follow-up AA implementation review returned
REVISE; blockers were addressed before this PR:acp_args=[]conflict is rejected;Tests
python3 -m py_compile tools/delegate_tool.pyuv run --with pytest python -m pytest tests/tools/test_delegate.py -q→148 passeduv run --with ruff ruff check tools/delegate_tool.py tests/tools/test_delegate.py→All checks passed!Related
Builds on / addresses the integrated enhancement proposed in #9459.