fix: surface command STT fallback usage - #50564
Open
Mushy-Snugglebites-badonkadonk wants to merge 4 commits into
Open
fix: surface command STT fallback usage#50564Mushy-Snugglebites-badonkadonk wants to merge 4 commits into
Mushy-Snugglebites-badonkadonk wants to merge 4 commits into
Conversation
Mushy-Snugglebites-badonkadonk
force-pushed
the
fix/command-stt-visible-fallback
branch
from
July 10, 2026 23:07
edd77a6 to
fc5efdf
Compare
teknium1
reviewed
Jul 14, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing a verified gap: current main returns a command-provider failure directly at tools/transcription_tools.py:1703-1711, so the configured local fallback is not currently reachable.
Problems
- The added
local_cfg = stt_config.get("local", {})can beNonewhen config containsstt.local: null; the following.get()then raises. Current native local dispatch usesstt_config.get("local") or {}attools/transcription_tools.py:1660, following the null-subsection fix in3a394210. fallback_provider/fallbackis new user-facing command-provider configuration, butwebsite/docs/user-guide/features/tts.md:546-553does not document either key.
Suggested changes
- Use the existing
or {}guard and add a null-stt.localregression test for this fallback path. - Add the fallback setting and semantics to the STT command-provider docs.
Automated hermes-sweeper review.
Mushy-Snugglebites-badonkadonk
force-pushed
the
fix/command-stt-visible-fallback
branch
from
July 19, 2026 02:49
fc5efdf to
763189c
Compare
Mushy-Snugglebites-badonkadonk
force-pushed
the
fix/command-stt-visible-fallback
branch
from
July 21, 2026 13:37
763189c to
32c75db
Compare
Mushy-Snugglebites-badonkadonk
force-pushed
the
fix/command-stt-visible-fallback
branch
from
July 29, 2026 20:10
32c75db to
3837b79
Compare
Contributor
|
Verified against current main ( Findings:
Recommendation: rebase onto main, apply the two review fixes, and re-request review. Lane 05's class (piper registry parity, probe install-safety, null-config guards) ships separately in #78202. |
This was referenced Aug 4, 2026
Mushy-Snugglebites-badonkadonk
force-pushed
the
fix/command-stt-visible-fallback
branch
from
August 10, 2026 17:36
3837b79 to
607950d
Compare
Mushy-Snugglebites-badonkadonk
force-pushed
the
fix/command-stt-visible-fallback
branch
from
August 10, 2026 17:52
607950d to
aa0a137
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fallback_provider: local(orfallback: local) is configured.stt.local: nullsafe and resolves the fallback through its own local-model configuration instead of leaking a command-provider model override.Validation
Rebased onto
mainat2b618fe7e5c31ea62a167a40b3b72c52a88047b2and verified with focused coverage for command-provider fallback, explicit-null local config, model-override isolation, fresh/pending transcript echoes, and raw clarify replies:git diff --checkalso passes. The full transcription-tools file has one unrelated Apple Silicon expectation failure that reproduces unchanged on the rebasedmaincommit; the focused PR coverage above is green.AI assistance disclosure
This PR was prepared with AI assistance under human direction and reviewed/tested locally before submission.