fix(desktop): treat dropped folders as context refs - #50424
Closed
DaveCharland wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the focused folder-drop investigation. Automated hermes-sweeper review found this behavior is already implemented on current
That commit is contained in release |
Author
|
Thanks Tec! You the man. Sorry again to hear about your bestie Link. I'm sure he and my precious angel Minnie and waiting for us on the other side of the rainbow bridge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file.attach.Why
Dragging a folder from the OS can arrive in the renderer with a native
Filehandle. The previous split treated every File-bearing drop as a file/image attachment candidate. For folders, that eventually calledfile.attachwith a directory path and no uploaded bytes, producing the gateway error:The fix probes the resolved path with the Desktop filesystem bridge before the file/image branch. If the path is a directory, the composer handles it as folder context.
Test plan