fix(ssh): quote remote workdir and path operands in one-shot execution - #5036
Closed
WAXLYY wants to merge 1 commit into
Closed
fix(ssh): quote remote workdir and path operands in one-shot execution#5036WAXLYY wants to merge 1 commit into
WAXLYY wants to merge 1 commit into
Conversation
Contributor
|
This is now fixed via PR #5629 (merged), which sanitizes workdir with tilde-aware shlex.quote + an allowlist validator. Thanks for flagging the vulnerability! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Quoted remote path operands embedded in SSH shell commands with
shlex.quote()intools/environments/ssh.py.This includes:
mkdir -ppath operandscatrm -fAlso added regression tests covering:
Why
The one-shot SSH execution path embedded
workdirdirectly into the remote shell command without quoting. This could lead to command injection and also broke valid directory paths containing spaces.Quoting these operands ensures they are treated as data by the remote shell and makes behavior consistent with the persistent shell path.
How to test
TERMINAL_ENV=sshandTERMINAL_SSH_PERSISTENT=falseusing:workdir="/tmp/a; touch /tmp/pwned #"workdir="/tmp/release artifacts"Validation
pytest tests/tools/test_ssh_environment.py -q→14 passed, 11 skippedpython -m compileall tools/environments/ssh.py tests/tools/test_ssh_environment.py→ successful