fix: reconnect stale MCP tool wrappers - #50162
Closed
gitgrooves wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Duplicate of #23540 — both add the same lazy/best-effort in-process MCP reconnect at the |
Author
|
Closed: opened in error; withdrawing this patch from public review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCP server '<name>' is not connectederror when rediscovery cannot recover the sessionTest Plan
uv run pytest tests/cron/test_scheduler_mcp_init.py tests/tools/test_mcp_stale_wrapper_reconnect.py -qContext
A long-running Hermes gateway can keep generated MCP tool wrappers after the underlying client session has gone stale/disconnected. Raw MCP endpoint health can be green while the active wrapper still returns not connected. This adds a best-effort reconnect path at wrapper invocation time before surfacing the error.