fix(auxiliary): sync missing provider aliases from models.py - #50116
Closed
ryptotalent wants to merge 1 commit into
Closed
fix(auxiliary): sync missing provider aliases from models.py#50116ryptotalent wants to merge 1 commit into
ryptotalent wants to merge 1 commit into
Conversation
_PROVIDER_ALIASES in auxiliary_client.py was missing 46 aliases that exist in hermes_cli/models.py (dashscope→alibaba, aws→bedrock, hf→ huggingface, nim→nvidia, deep-seek→deepseek, mimo→xiaomi, etc.). When users configured auxiliary.vision.provider: dashscope (or any of the other missing aliases), _normalize_aux_provider() returned the un-normalized string, causing the vision/compression/web_extract pipeline to silently fail with "couldn't be analyzed" because the provider was not recognized by resolve_provider_client(). Closes NousResearch#49464
alt-glitch
added
type/bug
3 tasks
Contributor
|
Closing in favor of a rebased PR against the latest |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_PROVIDER_ALIASESinagent/auxiliary_client.pywas missing 46 aliases that exist inhermes_cli/models.py. When users configuredauxiliary.vision.provider: dashscope(or any of the other missing aliases likeaws,hf,nim,deep-seek,mimo, etc.),_normalize_aux_provider()returned the un-normalized string, causing the vision/compression/web_extract pipeline to silently fail becauseresolve_provider_client()did not recognize the provider.Root Cause
_PROVIDER_ALIASESinauxiliary_client.py(line 165) is a manually-maintained subset of the canonical_PROVIDER_ALIASESinhermes_cli/models.py(line 1179). The two dicts drifted —models.pyhas 76 entries,auxiliary_client.pyhad only 30. The 46 missing entries include common aliases like:dashscopealibabaaws/amazonbedrockhfhuggingfacenimnvidiadeep-seekdeepseekmimoxiaomilm-studiolmstudioFix
Sync all missing aliases from
models.pyintoauxiliary_client.py. This is additive — existing aliases are unchanged, no behavior change for currently-working providers.Test Plan
TestNormalizeAuxProvidercovering all newly-added alias groupsTestNormalizeAuxProviderpass_normalize_aux_provider("dashscope")now returns"alibaba"(was returning"dashscope")Closes #49464