fix(openviking): synchronous prefetch with timeout guard - #49947
Closed
wgd753 wants to merge 1 commit into
Closed
Conversation
…h#33260+) Superset of PR NousResearch#33260 with additional hardening: - Synchronous POST /api/v1/search/find with current turn's query (instead of returning stale background cache from previous turn) - _PREFETCH_TIMEOUT = 1.5s prevents slow OV from blocking turn loop - _PREFETCH_MIN_SCORE = 0.35 noise filter (matches Claude Code plugin) - _derive_openviking_user_text() strips skill scaffolding from query - Uses limit field (same as queue_prefetch) instead of deprecated top_k - Reuses self._client (native codebase pattern) - Drains stale background cache on each call Ref: volcengine/OpenViking#2253, Hermes NousResearch#33260, NousResearch#5820
alt-glitch
added
type/perf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superset of #33260 with additional hardening.
Changes vs #33260
_PREFETCH_TIMEOUT = 1.5s_PREFETCH_MIN_SCOREconstant_derive_openviking_user_text()strips skill scaffoldingtop_k(deprecated?)limit(matches queue_prefetch)self._clientself._client(same)Why this matters
Without a timeout guard, the sync prefetch POST uses the 30s default
_TIMEOUT— a slow OV server would block the agent turn loop for 30s before every response.Related