Skip to content

docs: salvage 9 validated docs-update PRs (cluster) - #49914

Merged
teknium1 merged 11 commits into
mainfrom
hermes/hermes-7b9b9601
Jun 21, 2026
Merged

docs: salvage 9 validated docs-update PRs (cluster)#49914
teknium1 merged 11 commits into
mainfrom
hermes/hermes-7b9b9601

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Salvages 9 validated docs-update PRs onto current main as one cluster — each contributor commit cherry-picked with authorship preserved (rebase-merge). All premises re-verified against current main before inclusion.

Salvaged PRs

PR Author Change Validated
#48459 @liuhao1024 Remove non-existent conversation_entity from HA troubleshooting ✓ zero refs in HA code; doc still cited it
#48898 @Bartok9 Fix himalaya CLI arg order + --downloads-dir flag ✓ verified vs real himalaya v1.2.0 (move <TARGET> <ID>)
#48569 @baolingao zh-CN README: Windows "not supported" → native PowerShell ✓ EN README already documents native Windows; zh-CN was stale
#48439 @mkslzk README: document uv.exe antivirus false positive ✓ no existing AV note; real Win issue (#48411)
#49661 @Antimatter543 CONTRIBUTING: add "search first" guidance to cut duplicate PRs ✓ no search-first text on main
#48325 @graphanov MCP guide: document repo-record (Open Scaffold) workflow ✓ additive example, not present on main
#49444 @yapsrubricsz0 Regenerate skill docs (stale cross-links) + register tool-search in sidebar ✓ tool-search.md orphaned (on disk, not in sidebars.ts); faithful generator output
#49483 @Railway9784 Document model.context_length auto-detection resolution chain in hermes-agent skill ✓ skill didn't explain the /v1/models blocking behavior
#49177 @mintybasil Profile-distribution docs: make .gitignore mandatory before first commit ✓ closes a real author-side secret-leak footgun

Notes

Validation

liuhao1024 and others added 11 commits June 20, 2026 19:59
Closes #48835

The bundled himalaya skill and its website docs documented command
syntax that does not match Himalaya CLI v1.2.0.

Verified against pimalaya/himalaya v1.2.0 source:
- message move: MessageMoveCommand declares target_folder BEFORE
  envelopes (src/email/message/command/move.rs) -> usage is
  '<TARGET> <ID>...', so 'move 42 "Archive"' is wrong; correct is
  'move "Archive" 42'.
- message copy: same ordering in copy.rs.
- attachment download: AttachmentDownloadCommand exposes the flag as
  '-d, --downloads-dir <PATH>' (src/email/message/attachment/command/
  download.rs), not '--dir'.

Fixed in all three surfaces that carried the wrong examples:
- skills/email/himalaya/SKILL.md
- website/docs/.../email-himalaya.md
- website/i18n/zh-Hans/.../email-himalaya.md
…tive PowerShell

The Chinese README still told Windows users to install WSL2 and run
the Linux installer. Hermes now ships a native PowerShell install
script, so replace the outdated WSL2-only note with the direct
PowerShell one-liner.

Fixes: documentation accuracy / Windows onboarding
CONTRIBUTING.md had no pre-work search step; the only duplicate-check is a
PR-template checkbox that fires at review time, after the work is already done.
Add a "Before You Start: Search First" section near the top so contributors
search open and merged PRs and issues (and the source, since the tracker can
lag the code) before building. References #38284 (the agent-side analog).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
When model.context_length is set in config.yaml, it blocks auto-detection
from the server's /v1/models endpoint. The skill incorrectly implied a
hard fallback to 131072. Add the resolution chain and the fix command
(hermes config set model.context_length "") to both the config table
and a new troubleshooting section.
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-7b9b9601 vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 11278 on HEAD, 11276 on base (🆕 +2)

🆕 New issues (2):

Rule Count
unresolved-attribute 2
First entries
run_agent.py:2984: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`

✅ Fixed issues (1):

Rule Count
invalid-assignment 1
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`

Unchanged: 5912 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/docs Documentation improvements P3 Low — cosmetic, nice to have labels Jun 21, 2026
@teknium1
teknium1 merged commit e5e173e into main Jun 21, 2026
35 checks passed
@teknium1
teknium1 deleted the hermes/hermes-7b9b9601 branch June 21, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.