fix(doctor): audit WhatsApp bridge at its resolved HERMES_HOME dir (follow-up #49561) - #49890
Merged
Merged
Conversation
doctor's npm audit hardcoded PROJECT_ROOT/scripts/whatsapp-bridge. In read-only Docker installs the bridge deps live in the writable HERMES_HOME mirror (#49561), so node_modules was never found there and the bridge audit silently skipped. Resolve the dir through the shared resolve_whatsapp_bridge_dir() helper so doctor audits where deps actually install. Falls back to the install-tree path if the helper is unavailable.
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
invalid-assignment |
1 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`
✅ Fixed issues (2):
| Rule | Count |
|---|---|
unresolved-attribute |
2 |
First entries
run_agent.py:2984: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
Unchanged: 5912 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
alt-glitch
added
type/bug
kpadilha
pushed a commit
to kpadilha/hermes-agent
that referenced
this pull request
Jun 24, 2026
…ousResearch#49890) doctor's npm audit hardcoded PROJECT_ROOT/scripts/whatsapp-bridge. In read-only Docker installs the bridge deps live in the writable HERMES_HOME mirror (NousResearch#49561), so node_modules was never found there and the bridge audit silently skipped. Resolve the dir through the shared resolve_whatsapp_bridge_dir() helper so doctor audits where deps actually install. Falls back to the install-tree path if the helper is unavailable.
pai-scaffolde
pushed a commit
to pai-scaffolde/hermes-agent
that referenced
this pull request
Jun 28, 2026
…ousResearch#49890) doctor's npm audit hardcoded PROJECT_ROOT/scripts/whatsapp-bridge. In read-only Docker installs the bridge deps live in the writable HERMES_HOME mirror (NousResearch#49561), so node_modules was never found there and the bridge audit silently skipped. Resolve the dir through the shared resolve_whatsapp_bridge_dir() helper so doctor audits where deps actually install. Falls back to the install-tree path if the helper is unavailable.
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ousResearch#49890) doctor's npm audit hardcoded PROJECT_ROOT/scripts/whatsapp-bridge. In read-only Docker installs the bridge deps live in the writable HERMES_HOME mirror (NousResearch#49561), so node_modules was never found there and the bridge audit silently skipped. Resolve the dir through the shared resolve_whatsapp_bridge_dir() helper so doctor audits where deps actually install. Falls back to the install-tree path if the helper is unavailable.
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…ousResearch#49890) doctor's npm audit hardcoded PROJECT_ROOT/scripts/whatsapp-bridge. In read-only Docker installs the bridge deps live in the writable HERMES_HOME mirror (NousResearch#49561), so node_modules was never found there and the bridge audit silently skipped. Resolve the dir through the shared resolve_whatsapp_bridge_dir() helper so doctor audits where deps actually install. Falls back to the install-tree path if the helper is unavailable.
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…ousResearch#49890) doctor's npm audit hardcoded PROJECT_ROOT/scripts/whatsapp-bridge. In read-only Docker installs the bridge deps live in the writable HERMES_HOME mirror (NousResearch#49561), so node_modules was never found there and the bridge audit silently skipped. Resolve the dir through the shared resolve_whatsapp_bridge_dir() helper so doctor audits where deps actually install. Falls back to the install-tree path if the helper is unavailable.
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…ousResearch#49890) doctor's npm audit hardcoded PROJECT_ROOT/scripts/whatsapp-bridge. In read-only Docker installs the bridge deps live in the writable HERMES_HOME mirror (NousResearch#49561), so node_modules was never found there and the bridge audit silently skipped. Resolve the dir through the shared resolve_whatsapp_bridge_dir() helper so doctor audits where deps actually install. Falls back to the install-tree path if the helper is unavailable.
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…ousResearch#49890) doctor's npm audit hardcoded PROJECT_ROOT/scripts/whatsapp-bridge. In read-only Docker installs the bridge deps live in the writable HERMES_HOME mirror (NousResearch#49561), so node_modules was never found there and the bridge audit silently skipped. Resolve the dir through the shared resolve_whatsapp_bridge_dir() helper so doctor audits where deps actually install. Falls back to the install-tree path if the helper is unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #49839:
hermes doctor's npm audit hardcodedPROJECT_ROOT/scripts/whatsapp-bridge, so in read-only Docker installs — where the bridge deps now live in the writableHERMES_HOMEmirror (#49561) — doctor never foundnode_modulesthere and silently skipped the WhatsApp bridge audit.Changes
hermes_cli/doctor.py: resolve the bridge dir via the sharedresolve_whatsapp_bridge_dir()helper before auditing, so doctor audits the directory that actually holds the installed deps. Falls back to the install-tree path if the helper is unavailable.Validation
node_modulesnot at PROJECT_ROOT → audit silently skippedTargeted tests: 78/78 doctor tests green. Helper imports cleanly at runtime;
py_compilepasses.Infographic