fix(gateway): rewrite transcripts atomically - #4985
Closed
binhnt92 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
channel_directory looks fixed on main already. rewrite_transcript() still reproduces, so I'd keep this open but trim it to that part. |
binhnt92
force-pushed
the
fix/atomic-transcript-and-channel-directory-writes
branch
2 times, most recently
from
April 15, 2026 14:24
9819658 to
391afaf
Compare
binhnt92
force-pushed
the
fix/atomic-transcript-and-channel-directory-writes
branch
from
April 17, 2026 11:47
391afaf to
ea1e879
Compare
7 tasks
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewrite_transcript()still overwrites the legacy JSONL transcript with a bareopen(path, "w"). If the gateway dies mid-write during/retry,/undo, or/compress, the transcript file can be left empty or partially rewritten.This refresh trims the PR down to the still-reproducible bug on current
main.channel_directoryalready usesatomic_json_write(), so it is no longer partof the fix.
Changes Made
fsync()the temp file before replacing the original transcriptHow to Test
Checklist