fix(cronjob): add schedule and job_id to JSON schema required array

[tcconnally]

Summary

The cronjob tool schema declared only action as required, but schedule is needed for action=create and job_id is needed for action=update/pause/resume/remove/run. Strict JSON-schema-compliant models may omit parameters that are absent from the required array, causing the tool to return "schedule is required for create" even when the LLM read the description text and wanted to include it.

Root Cause

The schema at tools/cronjob_tools.py line 853 had:

"required": ["action"]

Both schedule and job_id were described as required for specific actions in the parameter descriptions but NOT in the JSON schema's required array. Models that strictly honor the JSON schema structure may skip them.

Fix

Added schedule and job_id to the required array:

"required": ["action", "schedule", "job_id"]

This is safe for non-applicable actions:

• schedule is only checked when action=create (line 504)
• job_id is only checked for update/pause/resume/remove/run (line 585)
• All other actions silently ignore irrelevant parameters

Pattern

This is a class-level fix — any multi-action tool with conditionally-required parameters can hit this when models hew to the JSON schema required array rather than description text. Other tools with similar patterns should be audited for the same gap.

Closes #49695

[teknium1]

Thanks for this — closing in favor of #53246, which fixes the same root cause (#34120) at the handler boundary.

The schema-required approach here would over-constrain the tool: schedule and job_id are action-specific, not globally required. list, remove, pause, resume, and run don't take a schedule, and create doesn't take a job_id — adding both to the global required array would reject every one of those calls. (Gille flagged the same thing in the support thread.)

#53246 instead coalesces the common schedule synonyms some models emit (cron, when, cron_expression, …) onto the canonical key at the dispatch boundary, with canonical always winning and empty-string falling through to aliases. That lets create succeed without changing what's required per action.

Appreciate you digging into this one.