fix: validate per-call workdir before passing to docker exec - #4978
Closed
bugkill3r wants to merge 1 commit into
Closed
fix: validate per-call workdir before passing to docker exec#4978bugkill3r wants to merge 1 commit into
bugkill3r wants to merge 1 commit into
Conversation
…earch#4669) When a terminal tool call includes an invalid workdir (e.g. containing path traversal), it was passed directly to docker exec -w, causing OCI runtime errors. Add _validate_workdir() that rejects non-absolute paths and paths containing "..", falling back to the configured session cwd.
Contributor
|
This is now fixed via PR #5629 (merged), which sanitizes workdir with tilde-aware shlex.quote + an allowlist validator. Thanks for flagging the vulnerability! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workdirvalues (e.g. containing..or non-absolute paths) were passed directly todocker exec -w, causing OCI runtime errors_validate_workdir()that rejects non-absolute paths and paths containing.., falling back to the configured session cwdTest plan
workdir— works as beforeworkdircontaining..— falls back to session cwd, logs warningworkdir— falls back to session cwd, logs warningworkdir— uses session cwd (default behavior preserved)