fix(kanban): surface terminal ACK relay failures - #49752
Conversation
59e5022 to
03b9e60
Compare
|
Thanks for making ACK delivery state visible. The failure needs to be recorded at the delivery boundary rather than inferred from worker handoff text. Problems
Suggested changes
This is an automated hermes-sweeper review. |
|
Recommend keeping this as the clean, reviewable implementation of the 'delivery-boundary failure receipt' item. It's self-contained: classify_ack_relay writes a durable, once-per-terminal-transition ack_relay_status event and _rule_missing_ack_relay surfaces it as an operator-facing diagnostic with recovery actions — something #37865/main only log at WARNING. No forbidden patterns (no chat_type=group, no model-exposed control, no schema alias); persistence is actually consumed, and the receipt is bounded (matched pattern id + short verdict token + status, no raw summary or secrets). Note this same commit is duplicated inside the larger, unreviewed #49593 (byte-identical kanban_diagnostics.py) — resolve that by dropping the commit from #49593, not by blocking this PR. Suggest rebasing on #37865 so the two land together. Nothing is closed by this note. (This PR is not closed.) |
(cherry picked from commit 2181f11f229ac8f3883323c737e8e5310fa47305) (cherry picked from commit 3fc98272507a64dae29fa00644a6237ea14ed0d9)
03b9e60 to
d0b8453
Compare
|
M28.6 refresh pushed: Evidence / changes:
Tests:
Mergeability: PR head is |
Summary
Tests
python3 -m pytest tests/hermes_cli/test_kanban_diagnostics.py tests/hermes_cli/test_kanban_notify.py -q -o addopts=python3 -m py_compile hermes_cli/kanban_db.py hermes_cli/kanban_diagnostics.py