Skip to content

fix(desktop): add tooltips to right sidebar header buttons - #49729

Merged
teknium1 merged 2 commits into
mainfrom
hermes/hermes-3aa07797
Jun 20, 2026
Merged

fix(desktop): add tooltips to right sidebar header buttons#49729
teknium1 merged 2 commits into
mainfrom
hermes/hermes-3aa07797

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

The three right-sidebar header icon buttons (Refresh, Open Folder, Collapse All) now show a hover tooltip — previously they only had aria-label (screen-reader only), so newcomers got no visible hint of what each button does.

Salvages #49697 by @alelpoan onto current main.

Changes

  • apps/desktop/src/app/right-sidebar/index.tsx: add title={r.refreshTree/openFolder/collapseAll} to the three header buttons (i18n keys already existed).
  • scripts/release.py: map alelpoan@proton.me in the author map.

Follow-up over the original PR

  • Re-indented the contributor's three lines from tabs to spaces via prettier so prettier --check passes.

Validation

Before After
Hover tooltip on the 3 buttons none shows localized label
prettier --check on the file fails (tabs) passes

Original PR: #49697

Infographic

tooltips-for-the-sidebar

alelpoan and others added 2 commits June 20, 2026 10:15
Re-indent the salvaged title= lines to spaces (prettier), and map
alelpoan@proton.me in the release author map.
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-3aa07797 vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 11228 on HEAD, 11230 on base (✅ -2)

🆕 New issues (1):

Rule Count
invalid-assignment 1
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`

✅ Fixed issues (2):

Rule Count
unresolved-attribute 2
First entries
run_agent.py:2984: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`

Unchanged: 5885 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/bug Something isn't working comp/tui Terminal UI (ui-tui/ + tui_gateway/) P3 Low — cosmetic, nice to have labels Jun 20, 2026
@alelpoan

Copy link
Copy Markdown
Contributor

Amazing infographic 😄

@teknium1
teknium1 merged commit 838daca into main Jun 20, 2026
35 checks passed
@teknium1
teknium1 deleted the hermes/hermes-3aa07797 branch June 20, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tui Terminal UI (ui-tui/ + tui_gateway/) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants