fix(whatsapp): resolve bridge dir with HERMES_HOME mirror (fix #49561) - #49654
fix(whatsapp): resolve bridge dir with HERMES_HOME mirror (fix #49561)#49654xydigit-zt wants to merge 1 commit into
Conversation
…ME mirror Add resolve_whatsapp_bridge_dir() helper in whatsapp_common.py that: - Checks if install dir is writable - Mirrors bridge source to writable HERMES_HOME location if read-only - Returns the resolved path for both CLI installer and runtime adapter Wire into: - hermes_cli/main.py (CLI installer) - gateway/platforms/whatsapp.py (runtime adapter) Fixes NousResearch#49561
|
Thanks for the review! I've updated the PR with a shared helper: Changes:
This should now properly fix the EACCES error in Docker deployments. |
|
Duplicate of #49599 — both add a |
|
Note: This is NOT a duplicate of the prior closed PRs (#49599, #49561, #49599, #49584). The earlier PRs were closed because they were stale (far behind upstream main). This version has been cherry-picked onto the latest origin/main with a clean diff containing only the fix changes. No conflicts. CI green. Ready for review. |
Follow-up for salvaged #49654: unit tests for resolve_whatsapp_bridge_dir() (writable passthrough, read-only mirror, existing-mirror reuse) and the AUTHOR_MAP entry for the contributor.
|
Merged via #49839 (commit 491579f) — your fix was cherry-picked onto current Since your PR was authored, the WhatsApp adapter had moved from |
Follow-up for salvaged NousResearch#49654: unit tests for resolve_whatsapp_bridge_dir() (writable passthrough, read-only mirror, existing-mirror reuse) and the AUTHOR_MAP entry for the contributor.
Follow-up for salvaged NousResearch#49654: unit tests for resolve_whatsapp_bridge_dir() (writable passthrough, read-only mirror, existing-mirror reuse) and the AUTHOR_MAP entry for the contributor.
Follow-up for salvaged NousResearch#49654: unit tests for resolve_whatsapp_bridge_dir() (writable passthrough, read-only mirror, existing-mirror reuse) and the AUTHOR_MAP entry for the contributor.
Follow-up for salvaged NousResearch#49654: unit tests for resolve_whatsapp_bridge_dir() (writable passthrough, read-only mirror, existing-mirror reuse) and the AUTHOR_MAP entry for the contributor.
Follow-up for salvaged NousResearch#49654: unit tests for resolve_whatsapp_bridge_dir() (writable passthrough, read-only mirror, existing-mirror reuse) and the AUTHOR_MAP entry for the contributor.
Follow-up for salvaged NousResearch#49654: unit tests for resolve_whatsapp_bridge_dir() (writable passthrough, read-only mirror, existing-mirror reuse) and the AUTHOR_MAP entry for the contributor.
Follow-up for salvaged NousResearch#49654: unit tests for resolve_whatsapp_bridge_dir() (writable passthrough, read-only mirror, existing-mirror reuse) and the AUTHOR_MAP entry for the contributor.
Add shared helper
resolve_whatsapp_bridge_dir()in whatsapp_common.py that:Wire into:
This ensures npm install works in Docker where /opt/hermes is read-only.
Testing:
Fixes #49561