fix(desktop): preserve profile when opening session routes

[d31tcjg]

Summary

• Preserve each Desktop session row's owning profile when opening sessions from sidebar and messaging sections, cron run lists, command center, command palette, keyboard/session pickers, and pop-out windows.
• Encode the optional profile hint in session routes, parse it during route resume, and carry it through cached and uncached session ownership resolution.
• Route getSession, message fallback, and session.resume through the same profile hint while preserving legacy fallback behavior when the hint is absent or stale.
• Carry the profile through the renderer window bridge, Electron IPC, secondary-window URL construction, and existing-window focus/reload paths.

Motivation

Desktop aggregates sessions from multiple profiles. A row owned by a non-active profile could previously navigate or open a secondary window using only its session ID. Resume then probed the active/default profile, leaving Desktop stuck loading or reporting session not found even though the session existed in its owning profile.

This update covers the complete current Desktop path rather than only the original sidebar/resume implementation. It also adapts the change to the split use-session-actions/index.ts and utils.ts layout now on main.

Compatibility

• Profile hints remain optional for existing callers.
• Blank profile values normalize to no hint.
• Resume retains fallback discovery when an explicit hint is stale or unavailable.
• No voice/audio changes are included in this PR.

Testing

• npm run test:ui --workspace apps/desktop -- src/store/windows.test.ts src/app/chat/sidebar/sessions-section.test.tsx src/app/routes.test.ts src/app/session/hooks/use-route-resume.test.tsx src/app/session/hooks/use-session-actions.test.tsx
  • 49 tests passed
• npm run test:desktop:platforms --workspace apps/desktop -- electron/session-windows.test.ts
  • 15 tests passed
• npm run typecheck --workspace apps/desktop
• Scoped ESLint over all 28 changed Desktop files; zero errors
• git diff --check origin/main...HEAD
• Added-line security/scope scan across 304 added lines; no findings and no voice/audio files

[teknium1]

Thanks for tracing the profile across the Desktop session-entry surfaces. The premise is confirmed on current main: a fresh secondary renderer starts with an empty $sessions store (apps/desktop/src/store/session.ts:200), while resolveStoredSession() first probes the active backend and then only the current $profiles cache (apps/desktop/src/app/session/hooks/use-session-actions/utils.ts:208-250). Gateway boot opens the socket before refreshSessions() completes (apps/desktop/src/app/gateway/hooks/use-gateway-boot.ts:450-476), so an unhinted cross-profile route can enter that lookup before ownership is available.

The proposed optional route hint directly addresses that cold path and preserves the existing fallback discovery behavior. The focused changes align with Electron's existing profile-aware API routing (apps/desktop/electron/main.ts:7903-7922).

This is an automated hermes-sweeper review.

[OutThisLife]

Thanks for tracing this across every Desktop session-entry surface — the map you built of where ownership gets dropped was accurate, and it's what made the residual gap easy to find.

We ended up fixing it from the other side. #74033 makes GET /api/sessions/{id} and GET /api/sessions stamp the owning profile unconditionally, rather than only when the request carries ?profile=. That was the actual asymmetry: the default profile is the one reachable without the param, so its rows were the only ones circulating unowned. With the server holding up its end, resolveStoredSession gets the right answer on its own and the route hint has nothing left to carry for this motivation.

One piece of your PR wasn't covered by that, though: hermes.desktop.lastRoute was still a single global key while lastSessionId had already been scoped per profile, and cold-start restore prefers the route. Since a session route embeds a session id, that bypassed the id scoping entirely. Salvaged as #74277 with credit to you.

Closing as superseded — the remaining diff here is a 149-file rebase against a fix that's already landed.

[d31tcjg]

Thank you for the clear explanation, and for salvaging the remembered-route fix with credit. I’m glad the investigation and session-entry mapping helped improve Hermes, even though the final solution landed through a different path. Happy to have contributed. 🙂