Skip to content

fix: stabilization fixes and architectural enhancements - #49523

Closed
aniruddhaadak80 wants to merge 13 commits into
NousResearch:mainfrom
aniruddhaadak80:stabilization-fixes-v2
Closed

fix: stabilization fixes and architectural enhancements#49523
aniruddhaadak80 wants to merge 13 commits into
NousResearch:mainfrom
aniruddhaadak80:stabilization-fixes-v2

Conversation

@aniruddhaadak80

@aniruddhaadak80 aniruddhaadak80 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Architectural improvement

@aniruddhaadak80
aniruddhaadak80 requested a review from a team June 20, 2026 07:58
@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery comp/cron Cron scheduler and job management P3 Low — cosmetic, nice to have labels Jun 20, 2026
@aniruddhaadak80
aniruddhaadak80 force-pushed the stabilization-fixes-v2 branch from 9c9f08a to 59fb14b Compare June 20, 2026 08:07
@alt-glitch alt-glitch added comp/dashboard Web dashboard / control panel UI (dashboard/, landing) comp/desktop Electron desktop app (apps/desktop/*) labels Jun 26, 2026
@teknium1 teknium1 added sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-caching Sweeper risk: may break/degrade prompt caching or cache-key stability (invariant) sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows sweeper:blast-broad Sweeper blast radius: broad — a core path most sessions hit labels Jul 14, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for assembling several useful fixes. The current branch needs selective salvage rather than a bulk merge.

Problems

  • The session_name change in cron/scheduler.py does not resume history as its added comment claims. Current execution still calls agent.run_conversation(prompt) at cron/scheduler.py:3139; run_agent.py persists SessionDB messages (run_agent.py:1755) but does not load a transcript for this cron path.
  • The PR adds prompt_cache_ttl and ANTHROPIC_CACHE_TTL in hermes_cli/config.py, but the PR diff has no prompt_cache_ttl consumer. ANTHROPIC_CACHE_TTL is also a non-secret behavioral .env setting, contrary to AGENTS.md:102-106.
  • Current /reload-skills intentionally preserves the prompt cache (agent/skill_commands.py:412-416; gateway/slash_commands.py:4208-4218), so the proposed cache invalidation needs a focused design decision.

Suggested changes

  • Salvage the null prior-session finalize guard separately; current gateway/slash_commands.py:225-237 still invokes the hook with a nullable ID.
  • Rework or remove session_name persistence and the unconsumed cache settings.

Automated hermes-sweeper review.

@aniruddhaadak80

Copy link
Copy Markdown
Contributor Author

Closing as superseded — the reviewable pieces of this broad stabilization bundle have been rebuilt as focused PRs against current main, where they are actively being reviewed:

The remaining ~60-file bulk of this branch predates thousands of upstream commits (api_server alone differs by >4000 lines) and can no longer be verified or merged safely — a squash would silently revert current main fixes. If a specific fix from this bundle still reproduces on current main, please open it as an issue or a single-purpose PR and it will get proper attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management comp/dashboard Web dashboard / control panel UI (dashboard/, landing) comp/desktop Electron desktop app (apps/desktop/*) comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have sweeper:blast-broad Sweeper blast radius: broad — a core path most sessions hit sweeper:risk-caching Sweeper risk: may break/degrade prompt caching or cache-key stability (invariant) sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/refactor Code restructuring, no behavior change

Projects

None yet

3 participants