Fix desktop memory provider built-in option - #49514
Conversation
|
Related: #49513 (the issue this PR Closes), #12990 (adjacent memory-provider UX: CLI Note: the genuine scope of this PR is the desktop Memory Provider dropdown fix ( |
d847a6e to
2ff69df
Compare
|
Thanks, you were right. I rebased the branch onto a clean The PR now contains one commit and no longer includes the Telegram voice-duration or release author-map files. While resolving the rebase I kept the newer external Re-ran the focused checks:
|
2ff69df to
4850715
Compare
4850715 to
5a86f5e
Compare
5a86f5e to
de5d648
Compare
|
Thanks for the focused desktop fix. The premise is verified on current main: The PR's desktop-side normalization, blank-value label, removal of the misleading option, and alias regression coverage align with that existing backend contract. No additional correctness or design-fit issue was found in the nine-file diff. Automated hermes-sweeper review. |
Summary
memory.provideras the built-in memory option in Desktop Settings.builtinplugin option from the provider dropdown.Why
Built-in persistent memory is the default
MEMORY.md/USER.mdlayer. Thememory.providersetting selects an external provider plugin that runs alongside it.Desktop Settings exposed
builtinas if it were a provider plugin. Selecting it could also render plugin setup controls for a provider that does not exist. The backend already normalizesbuilt-in,builtin, andnoneto the blank built-in value; this change applies the same contract in the desktop UI.Closes #49513
Tests
npm --prefix apps/desktop run test:ui -- src/app/settings/helpers.test.ts→ 22 passednpm --prefix apps/desktop run typecheck→ passed--quiet→ passedgit diff --check upstream/main...HEAD→ passed