-
Notifications
You must be signed in to change notification settings - Fork 46.7k
fix: use clean user message for auto-title instead of skill-bloated input #4946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dieutx
wants to merge
1
commit into
NousResearch:main
Choose a base branch
from
dieutx:fix/auto-title-use-clean-user-message
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| """Tests for auto-title using clean user message instead of skill-bloated input. | ||
|
|
||
| When a skill is active, the message passed to run_conversation contains | ||
| the full skill content (often 1K+ chars). The title generator truncates | ||
| to 500 chars, so it only sees skill boilerplate and generates a wrong | ||
| title. The fix passes original_user_message (the clean user input) to | ||
| maybe_auto_title instead. | ||
| """ | ||
|
|
||
| from agent.title_generator import _TITLE_PROMPT | ||
|
|
||
|
|
||
| class TestResultIncludesOriginalMessage: | ||
|
|
||
| def test_result_dict_has_original_user_message(self): | ||
| """run_conversation result must include original_user_message.""" | ||
| # Simulate a result dict | ||
| result = { | ||
| "final_response": "Here are some cat gifs!", | ||
| "original_user_message": "find me funny cat gifs", | ||
| "messages": [], | ||
| } | ||
| assert "original_user_message" in result | ||
| assert result["original_user_message"] == "find me funny cat gifs" | ||
|
|
||
| def test_clean_message_preferred_over_bloated(self): | ||
| """When original_user_message exists, use it over raw message.""" | ||
| bloated_message = "[SYSTEM: skill content 1000 chars...] find cats" | ||
| result = {"original_user_message": "find cats"} | ||
|
|
||
| title_input = result.get("original_user_message") or bloated_message | ||
| assert title_input == "find cats" | ||
| assert len(title_input) < 50 # not the 1000+ char bloated version | ||
|
|
||
| def test_fallback_to_message_when_no_original(self): | ||
| """When original_user_message is missing, fall back to raw message.""" | ||
| message = "hello world" | ||
| result = {} | ||
|
|
||
| title_input = result.get("original_user_message") or message | ||
| assert title_input == "hello world" | ||
|
|
||
| def test_title_prompt_fits_clean_input(self): | ||
| """Title prompt truncates to 500 chars — clean input fits easily.""" | ||
| clean_input = "find me funny cat gifs" | ||
| assert len(clean_input) < 500 # will be fully visible to title LLM | ||
|
|
||
| bloated = "[SYSTEM: ...skill...] " * 50 + clean_input | ||
| assert len(bloated) > 500 # would be truncated, hiding the actual intent |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
original_user_messageis not guaranteed to be clean skill input: the turn setup defines it aspersist_user_messageonly when supplied, otherwise the model-facinguser_message(currentagent/turn_context.py:304; PR baserun_agent.py:7925). Normal CLI and gateway skill paths pass the expanded payload without that override, so this field would still contain the skill body. Use the canonical skill-instruction extractor before title generation instead.