fix(install): keep managed node private - #49426
Closed
Bruce-anle wants to merge 3 commits into
Closed
Bruce-anle wants to merge 3 commits into
Bruce-anle wants to merge 3 commits into
Conversation
背景: Hermes POSIX installers linked managed node/npm/npx into user-global command directories, which shadowed user Node managers and persisted after update. 变更点: Add a shared Python node_runtime helper, remove shell symlink creation, add process-local PATH augmentation, and clean legacy Hermes-owned node links during update, TUI bootstrap, dependency ensure, and uninstall. 测试或冒烟结果: - /home/brucean/.hermes/hermes-agent/venv/bin/python -m pytest tests/hermes_cli/test_node_runtime.py tests/hermes_cli/test_dep_ensure.py tests/hermes_cli/test_tui_resume_flow.py tests/hermes_cli/test_cmd_update.py tests/hermes_cli/test_uninstall_node_symlinks.py tests/test_install_sh_node_global_prefix.py -q - bash -n scripts/install.sh - bash -n scripts/lib/node-bootstrap.sh - git diff --cached --check
背景: Independent review found two remaining Node runtime gaps: node-bootstrap accepted Node versions below the desktop build floor, and update could prepend Hermes-managed Node while running a user PATH npm. 变更点: Sync node-bootstrap.sh version checks with ^20.19 || >=22.12, and make update only prepend Hermes-managed Node when npm is private or the PATH Node is missing/too old. 测试或冒烟结果: - /home/brucean/.hermes/hermes-agent/venv/bin/python -m pytest tests/hermes_cli/test_node_runtime.py tests/hermes_cli/test_dep_ensure.py tests/hermes_cli/test_tui_resume_flow.py tests/hermes_cli/test_cmd_update.py tests/hermes_cli/test_uninstall_node_symlinks.py tests/test_install_sh_node_global_prefix.py -q - bash -n scripts/install.sh - bash -n scripts/lib/node-bootstrap.sh - git diff --check
背景: Independent follow-up review found HERMES_NODE_MIN_VERSION was documented as configurable even though node-bootstrap now enforces the fixed desktop build floor. 变更点: Remove the stale HERMES_NODE_MIN_VERSION input and update node-bootstrap documentation to name the ^20.19 || >=22.12 floor. 测试或冒烟结果: - /home/brucean/.hermes/hermes-agent/venv/bin/python -m pytest tests/test_install_sh_node_global_prefix.py -q - bash -n scripts/lib/node-bootstrap.sh - git diff --check
13 tasks
Collaborator
|
Closing — same as #47897. The managed-Node prefix hijack is already solved on This PR's new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Related
Test Plan
Notes