Skip to content

fix(cron): fall back to default scripts dir when running under a profile (#49158) - #49319

Closed
kyssta-exe wants to merge 1 commit into
NousResearch:mainfrom
kyssta-exe:auto-fix/issue-49158
Closed

fix(cron): fall back to default scripts dir when running under a profile (#49158)#49319
kyssta-exe wants to merge 1 commit into
NousResearch:mainfrom
kyssta-exe:auto-fix/issue-49158

Conversation

@kyssta-exe

Copy link
Copy Markdown
Contributor

Fixes #49158. When a gateway runs under a profile (e.g., personal), HERMES_HOME is set to ~/.hermes/profiles/personal, causing script resolution to look in the profile's scripts/ directory instead of the shared ~/.hermes/scripts/. This adds a fallback: if a relative script path is not found in the profile's scripts dir, also check the default HERMES_HOME/scripts/ directory. The fallback is path-traversal validated to prevent escape.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cron Cron scheduler and job management labels Jun 19, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Related: #41008 (open, patches SKILLS_DIR in profile context — different mechanism, same profile script/skill resolution concern) and #40918 (closed earlier attempt). This PR adds a runtime fallback in _run_job_script to the default HERMES_HOME/scripts/ dir, path-traversal validated. Fixes #49158.

@kyssta-exe

Copy link
Copy Markdown
Contributor Author

Stale — 24-26 days without merge activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cron Cron scheduler and job management P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cron scripts without explicit profile resolve to profiles/personal/scripts/

2 participants