feat(tui): ctrl+a toggle to hide unconfigured providers in the model picker - #49296
feat(tui): ctrl+a toggle to hide unconfigured providers in the model picker#49296SilentKnight87 wants to merge 1 commit into
Conversation
ff632ea to
bf7cc95
Compare
|
Updated this branch against current
Resolution kept the configured-only query key behavior and preserved the newer upstream Local validation after the merge:
I also ran the broader targeted Python files ( GitHub now reports the PR as mergeable; waiting on repository checks/review state. |
d17608b to
c732ef9
Compare
|
Rescoped following #60514. The original version of this PR (June 19) implemented configured-only filtering across the backend, desktop, and TUI; #60514 has since landed the backend params and desktop defaults in response to #56974, so this PR now carries only the remaining surface — a |
|
Thanks for narrowing this to the remaining TUI surface. The current picker still unconditionally requests Problems
Suggested changes
Automated hermes-sweeper review. |
What does this PR do?
Adds a
^atoggle to the TUI model picker's provider stage that hides providers the user hasn't explicitly configured — the same explicit-providers subset the desktop chat picker now defaults to after #60514.History / scope note: as originally filed (June 19) this PR implemented configured-only filtering across CLI/REST/gateway/desktop/TUI. #60514 (fixing #56974) has since landed the backend params (
explicit_only,include_unconfigured) and the desktop-picker defaults, so this PR is rescoped to the surface it left open: the TUI picker deliberately keeps the full provider universe for setup affordances ("paste KEY to activate"), and this change adds user control without touching that default.Type of Change
Changes Made
ui-tui/src/components/modelPicker.tsx^ain the provider stage toggles between the full universe (include_unconfigured: true— unchanged default) and explicitly configured providers (explicit_only: true, reusing the param introduced by fix: limit desktop model pickers to explicit providers (#56974) #60514).model.optionsrequest params extracted into a puremodelOptionsRequestParamshelper; refetch effect gains a cancellation guard and loading state on toggle.^a hide unconfigured↔^a show all.ui-tui/src/__tests__/modelPicker.test.tsrefreshpreservation.How to Test
/modelpicker — full provider list with setup rows, as today.^a— only explicitly configured providers remain (matches the desktop chat picker subset).^aagain — full list returns. Filter and selection state reset cleanly on toggle.Checklist
Screenshots / Logs
npm exec --workspace ui-tui prettier -- --check— passnpm run typecheck --workspace ui-tui— passnpm run test --workspace ui-tui -- src/__tests__/modelPicker.test.ts src/__tests__/providers.test.ts— 16 passed