fix(gateway): bypass active-session queueing for slash commands - #4925
Closed
canderson26 wants to merge 1 commit into
Closed
fix(gateway): bypass active-session queueing for slash commands#4925canderson26 wants to merge 1 commit into
canderson26 wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/approve alwaysduring an active sessionRoot cause
Adapter-level session serialization in
BasePlatformAdapter.handle_message()queued all follow-up messages behind an active session before gateway command dispatch ran. That meant control-plane commands like/approveand/denycould be queued instead of processed immediately while the agent thread was blocked waiting for approval, leading to 300s timeouts and poisoned follow-up turns.Why this fix
Gateway slash commands are control-plane operations and should bypass adapter-level active-session queueing. The gateway already has explicit logic to resolve
/approve,/deny,/stop,/new, etc. while an agent is running; this change lets those commands actually reach that logic in time.