Skip to content

fix(models): live-first merge + update opencode-zen catalog + uncap aggregator picker - #49129

Closed
Afnath-max wants to merge 1 commit into
NousResearch:mainfrom
Afnath-max:fix/stale-models
Closed

fix(models): live-first merge + update opencode-zen catalog + uncap aggregator picker#49129
Afnath-max wants to merge 1 commit into
NousResearch:mainfrom
Afnath-max:fix/stale-models

Conversation

@Afnath-max

@Afnath-max Afnath-max commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixed stale/deprecated models in the OpenCode Zen model picker dropdown.

Problem

The model picker showed models that no longer exist:

Removed (deprecated):

  • glm-4.7 — deprecated Mar 15
  • glm-4.6 — deprecated Mar 15
  • kimi-k2 — deprecated Mar 6
  • kimi-k2-thinking — deprecated Mar 6
  • minimax-m2.1 — deprecated Mar 15
  • minimax-m2.5-free — not in current docs
  • gemini-3-pro — deprecated Mar 9
  • claude-3-5-haiku — deprecated Feb 16
  • qwen3-coder — not in current docs

Added (current):

  • gpt-5.5, gpt-5.5-pro, gpt-5.4-mini, gpt-5.4-nano, gpt-5.3-codex-spark
  • claude-fable-5, claude-opus-4-8, claude-opus-4-7
  • gemini-3.5-flash, minimax-m3-free, glm-5.1
  • deepseek-v4-pro, deepseek-v4-flash, deepseek-v4-flash-free
  • qwen3.6-plus, qwen3.6-plus-free, qwen3.5-plus
  • grok-build-0.1, mimo-v2.5-free, north-mini-code-free, nemotron-3-ultra-free

Design Decision: Live-First for Aggregators

The upstream design (commit 658ac1d) uses curated-first for single providers (e.g., kimi) to surface newest models even when live API lags.

However, OpenCode Zen is an aggregator, not a single provider. Its live API is the authoritative catalog. The curated list is a fallback for models the live endpoint hasn't caught up on — not the primary source.

Therefore, for aggregators only, I propose live-first ordering:

  • Live API models appear first (provider's current catalog)
  • Curated-only models append as fallback (discovery)
  • Stale curated entries don't pollute the top of the picker

This does NOT change the curated-first behavior for single providers.

Files Changed

  • hermes_cli/models.py — updated catalog + live-first for aggregators
  • hermes_cli/model_switch.py — uncapped picker for opencode-zen
  • 3 test files — updated assertions

Testing

  • All existing tests pass (24/24)
  • New regression test for uncapped picker
  • Curated list matches live API exactly (48/48 models)

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard labels Jun 19, 2026
@teknium1 teknium1 mentioned this pull request Jun 28, 2026
Merged
teknium1 added a commit that referenced this pull request Jun 28, 2026
@teknium1
fix(models): scope live-first picker merge to opencode aggregators only
f54c528 
Follow-up to the salvaged #49129 commit. The original change flipped the
shared generic-provider merge in provider_model_ids() to live-first
unconditionally, which regressed curated-first for single providers
(kimi/zai, #46309) — and the PR encoded that regression by flipping the
kimi-coding and zai test assertions to expect live-first.

Gate live-first on an explicit _LIVE_FIRST_PICKER_PROVIDERS set
({opencode-zen, opencode-go}); every other provider keeps curated-first.
Also widen the uncapped picker + live-first sets to opencode-go, which has
the same 70+ model catalog problem as opencode-zen. Restore the
kimi-coding curated-first test and rewrite the merge-order test to assert
the per-provider contract.
teknium1 added a commit that referenced this pull request Jun 28, 2026
@teknium1
chore(release): map salvaged contributor emails for #49129 and #51488
c72d687
teknium1 added a commit that referenced this pull request Jun 28, 2026
@teknium1
docs(infographic): model picker fixes (#49129 + #51488)
b304023
@teknium1

teknium1 commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Salvaged and merged via PR #53977 (#53977). Your commit was cherry-picked onto current main with your authorship preserved (commit f98ffbc). One follow-up on top: the live-first merge was scoped to opencode-zen/opencode-go only, so single providers (kimi/zai) keep curated-first per #46309 — the unconditional version would have flipped that. Catalog refresh + uncapped aggregator picker landed as-is. Thanks!

@teknium1 teknium1 closed this Jun 28, 2026
@teknium1 teknium1 mentioned this pull request Jun 28, 2026
Closed
19 tasks
pai-scaffolde pushed a commit to pai-scaffolde/hermes-agent that referenced this pull request Jun 28, 2026
@teknium1 @pai-scaffolde
fix(models): scope live-first picker merge to opencode aggregators only
13d55d7 
Follow-up to the salvaged NousResearch#49129 commit. The original change flipped the
shared generic-provider merge in provider_model_ids() to live-first
unconditionally, which regressed curated-first for single providers
(kimi/zai, NousResearch#46309) — and the PR encoded that regression by flipping the
kimi-coding and zai test assertions to expect live-first.

Gate live-first on an explicit _LIVE_FIRST_PICKER_PROVIDERS set
({opencode-zen, opencode-go}); every other provider keeps curated-first.
Also widen the uncapped picker + live-first sets to opencode-go, which has
the same 70+ model catalog problem as opencode-zen. Restore the
kimi-coding curated-first test and rewrite the merge-order test to assert
the per-provider contract.
pai-scaffolde pushed a commit to pai-scaffolde/hermes-agent that referenced this pull request Jun 28, 2026
@teknium1 @pai-scaffolde
chore(release): map salvaged contributor emails for NousResearch#49129 …
f655565 
…and NousResearch#51488
pai-scaffolde pushed a commit to pai-scaffolde/hermes-agent that referenced this pull request Jun 28, 2026
@teknium1 @pai-scaffolde
docs(infographic): model picker fixes (NousResearch#49129 + NousResea…
a1308ce 
…rch#51488)
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
@teknium1
fix(models): scope live-first picker merge to opencode aggregators only
55f4a3f 
Follow-up to the salvaged NousResearch#49129 commit. The original change flipped the
shared generic-provider merge in provider_model_ids() to live-first
unconditionally, which regressed curated-first for single providers
(kimi/zai, NousResearch#46309) — and the PR encoded that regression by flipping the
kimi-coding and zai test assertions to expect live-first.

Gate live-first on an explicit _LIVE_FIRST_PICKER_PROVIDERS set
({opencode-zen, opencode-go}); every other provider keeps curated-first.
Also widen the uncapped picker + live-first sets to opencode-go, which has
the same 70+ model catalog problem as opencode-zen. Restore the
kimi-coding curated-first test and rewrite the merge-order test to assert
the per-provider contract.
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
@teknium1
chore(release): map salvaged contributor emails for NousResearch#49129 …
2833774 
…and NousResearch#51488
Jasper6439 pushed a commit to Jasper6439/hermes-agent that referenced this pull request Jul 5, 2026
@teknium1 Jasper6439
fix(models): scope live-first picker merge to opencode aggregators only
f6becd2 
Follow-up to the salvaged NousResearch#49129 commit. The original change flipped the
shared generic-provider merge in provider_model_ids() to live-first
unconditionally, which regressed curated-first for single providers
(kimi/zai, NousResearch#46309) — and the PR encoded that regression by flipping the
kimi-coding and zai test assertions to expect live-first.

Gate live-first on an explicit _LIVE_FIRST_PICKER_PROVIDERS set
({opencode-zen, opencode-go}); every other provider keeps curated-first.
Also widen the uncapped picker + live-first sets to opencode-go, which has
the same 70+ model catalog problem as opencode-zen. Restore the
kimi-coding curated-first test and rewrite the merge-order test to assert
the per-provider contract.
Jasper6439 pushed a commit to Jasper6439/hermes-agent that referenced this pull request Jul 5, 2026
@teknium1 Jasper6439
chore(release): map salvaged contributor emails for NousResearch#49129 …
f1d07e9 
…and NousResearch#51488
Jasper6439 pushed a commit to Jasper6439/hermes-agent that referenced this pull request Jul 5, 2026
@teknium1 Jasper6439
docs(infographic): model picker fixes (NousResearch#49129 + NousResea…
7ac8024 
…rch#51488)
habarmc1223-sudo pushed a commit to habarmc1223-sudo/hermes-agent-fluxmem that referenced this pull request Jul 8, 2026
@teknium1
fix(models): scope live-first picker merge to opencode aggregators only
c77463f 
Follow-up to the salvaged NousResearch#49129 commit. The original change flipped the
shared generic-provider merge in provider_model_ids() to live-first
unconditionally, which regressed curated-first for single providers
(kimi/zai, NousResearch#46309) — and the PR encoded that regression by flipping the
kimi-coding and zai test assertions to expect live-first.

Gate live-first on an explicit _LIVE_FIRST_PICKER_PROVIDERS set
({opencode-zen, opencode-go}); every other provider keeps curated-first.
Also widen the uncapped picker + live-first sets to opencode-go, which has
the same 70+ model catalog problem as opencode-zen. Restore the
kimi-coding curated-first test and rewrite the merge-order test to assert
the per-provider contract.
habarmc1223-sudo pushed a commit to habarmc1223-sudo/hermes-agent-fluxmem that referenced this pull request Jul 8, 2026
@teknium1
chore(release): map salvaged contributor emails for NousResearch#49129 …
0dd493f 
…and NousResearch#51488
habarmc1223-sudo pushed a commit to habarmc1223-sudo/hermes-agent-fluxmem that referenced this pull request Jul 8, 2026
@teknium1
docs(infographic): model picker fixes (NousResearch#49129 + NousResea…
b6b157b 
…rch#51488)
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
@teknium1
fix(models): scope live-first picker merge to opencode aggregators only
b5c8948 
Follow-up to the salvaged NousResearch#49129 commit. The original change flipped the
shared generic-provider merge in provider_model_ids() to live-first
unconditionally, which regressed curated-first for single providers
(kimi/zai, NousResearch#46309) — and the PR encoded that regression by flipping the
kimi-coding and zai test assertions to expect live-first.

Gate live-first on an explicit _LIVE_FIRST_PICKER_PROVIDERS set
({opencode-zen, opencode-go}); every other provider keeps curated-first.
Also widen the uncapped picker + live-first sets to opencode-go, which has
the same 70+ model catalog problem as opencode-zen. Restore the
kimi-coding curated-first test and rewrite the merge-order test to assert
the per-provider contract.
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
@teknium1
chore(release): map salvaged contributor emails for NousResearch#49129 …
b4e709b 
…and NousResearch#51488
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
@teknium1
docs(infographic): model picker fixes (NousResearch#49129 + NousResea…
abfe8fe 
…rch#51488)
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
@teknium1
fix(models): scope live-first picker merge to opencode aggregators only
35ef40d 
Follow-up to the salvaged NousResearch#49129 commit. The original change flipped the
shared generic-provider merge in provider_model_ids() to live-first
unconditionally, which regressed curated-first for single providers
(kimi/zai, NousResearch#46309) — and the PR encoded that regression by flipping the
kimi-coding and zai test assertions to expect live-first.

Gate live-first on an explicit _LIVE_FIRST_PICKER_PROVIDERS set
({opencode-zen, opencode-go}); every other provider keeps curated-first.
Also widen the uncapped picker + live-first sets to opencode-go, which has
the same 70+ model catalog problem as opencode-zen. Restore the
kimi-coding curated-first test and rewrite the merge-order test to assert
the per-provider contract.
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
@teknium1
chore(release): map salvaged contributor emails for NousResearch#49129 …
366509f 
…and NousResearch#51488
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
@teknium1
docs(infographic): model picker fixes (NousResearch#49129 + NousResea…
fc5b8e2 
…rch#51488)
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
@teknium1
fix(models): scope live-first picker merge to opencode aggregators only
2f41ca0 
Follow-up to the salvaged NousResearch#49129 commit. The original change flipped the
shared generic-provider merge in provider_model_ids() to live-first
unconditionally, which regressed curated-first for single providers
(kimi/zai, NousResearch#46309) — and the PR encoded that regression by flipping the
kimi-coding and zai test assertions to expect live-first.

Gate live-first on an explicit _LIVE_FIRST_PICKER_PROVIDERS set
({opencode-zen, opencode-go}); every other provider keeps curated-first.
Also widen the uncapped picker + live-first sets to opencode-go, which has
the same 70+ model catalog problem as opencode-zen. Restore the
kimi-coding curated-first test and rewrite the merge-order test to assert
the per-provider contract.
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
@teknium1
chore(release): map salvaged contributor emails for NousResearch#49129 …
6c8d530 
…and NousResearch#51488
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
@teknium1
docs(infographic): model picker fixes (NousResearch#49129 + NousResea…
3af63cb 
…rch#51488)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Afnath-max @teknium1 @alt-glitch