fix(type-annotation): replace Optional[callable] with Optional[Callable[..., None]] - #49072
Closed
blut-agent wants to merge 1 commit into
Closed
fix(type-annotation): replace Optional[callable] with Optional[Callable[..., None]]#49072blut-agent wants to merge 1 commit into
blut-agent wants to merge 1 commit into
Conversation
…le[..., None]] The builtin callable is not a valid generic type for static type checkers. Using Optional[callable] works at runtime but flags errors in strict mypy/pyright mode. All 4 instances replaced with proper Callable types: - hermes_cli/dingtalk_auth.py: on_waiting parameter - tools/delegate_tool.py: _build_child_progress_callback return type - agent/conversation_loop.py: stream_callback parameter - gateway/stream_consumer.py: on_new_message parameter This is a regression of PR NousResearch#45651 which fixed 7 instances in June but new code re-introduced 4 more since then.
alt-glitch
added
type/refactor
This was referenced Jun 21, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace 4 instances of
Optional[callable](Python builtincallable) with properOptional[Callable[...]]fromtyping.The builtin
callable(lowercase) is not a valid generic type for static type checkers. UsingOptional[callable]works at runtime but will flag errors in strict mypy/pyright mode.Changes
hermes_cli/dingtalk_auth.pyon_waitingparamOptional[callable]Optional[Callable[[], None]]tools/delegate_tool.pyOptional[callable]Optional[Callable[..., None]]agent/conversation_loop.pystream_callbackparamOptional[callable]Optional[Callable[[], None]]gateway/stream_consumer.pyon_new_messageparamOptional[callable]Optional[Callable[[], None]]Context
This is a regression of PR #45651 (2026-06-13) which fixed 7 instances across 6 files. New code added since then re-introduced 4 more instances.
Impact
Optional[callable]errors in strict mypy/pyright modecallableandCallableare equivalent at runtime