fix(debug): include gui.log (dashboard/TUI/pty/websocket) in hermes debug share - #48981
Merged
Merged
Conversation
Contributor
🔎 Lint report:
|
alt-glitch
added
type/feature
This was referenced Jun 19, 2026
…ebug share gui.log was registered in hermes_cli/logs.py::LOG_FILES (and surfaced by `hermes logs gui`) but was never wired into `hermes debug share`. The share report captured agent/errors/gateway/desktop tails plus full agent/gateway/ desktop logs — but nothing from gui.log, the surface the dashboard, TUI-over- PTY bridge, and websocket layer (hermes_cli.web_server / pty_bridge / tui_gateway) actually write to. A user reporting a dashboard or TUI bug shared zero breadcrumbs from the broken surface. Wire gui.log through all three share surfaces, matching the existing pattern: - _capture_default_log_snapshots(): capture the gui snapshot (redacted like the rest) - collect_debug_report(): add the gui.log summary tail block - build_debug_share(): pull gui full_text, prepend dump header + redaction banner, add to the upload loop - run_debug_share() --local branch: same, plus the local print block - _PRIVACY_NOTICE: name gui.log in both bullets Redaction is inherited for free — the gui snapshot goes through the same _capture_log_snapshot(..., redact=redact) path, so secrets are scrubbed in both the tail and full text (verified E2E: seeded key masked by default, passes through under --no-redact, raw token never leaks). Tests: seed gui.log in the fixture, add test_report_includes_gui_log, and bump the upload-count tripwire 4->5 (test_share_uploads_five_pastes).
teknium1
force-pushed
the
fix/debug-share-gui-log
branch
from
June 19, 2026 13:44
e2fff57 to
0b61ab5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes debug sharenow capturesgui.log— the surface the dashboard, TUI-over-PTY bridge, and websocket layer (hermes_cli.web_server/hermes_cli.pty_bridge/tui_gateway) actually write to. Previously a user reporting a dashboard or TUI/desktop bug shared zero breadcrumbs from the broken surface, even thoughgui.logwas already inLOG_FILESand surfaced byhermes logs gui.Salvage of #48981 by @kshitijk4poor, cherry-picked onto current
mainwith authorship preserved.Changes
hermes_cli/debug.py: wireguithrough all four share surfaces —_capture_default_log_snapshots(redacted snapshot),collect_debug_report(tail block),build_debug_share(full-log dump header + redaction banner + upload loop),run_debug_share --localbranch (full text + print block); namegui.login both_PRIVACY_NOTICEbullets.tests/hermes_cli/test_debug.py: newtest_report_includes_gui_log; four→five-pastes upload test.website/docs/reference/cli-commands.md:debug sharedescription now lists GUI/dashboard logs.Redaction is inherited for free — the
guisnapshot goes through the same_capture_log_snapshot(..., redact=redact)boundary as every other log.Validation
scripts/run_tests.sh tests/hermes_cli/test_debug.py— 75 passed.hermes debug share --localagainst a tempHERMES_HOME:gui.logtail block,FULL gui.logsection, and--- full gui.log ---header all present; a seeded vendor-prefixed key ingui.logwas masked (raw token absent).Infographic