Skip to content

fix(fallback): honor explicit base_url and api_key config #4895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
canderson26 wants to merge 1 commit into from
Closed

fix(fallback): honor explicit base_url and api_key config #4895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion run_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4520,8 +4520,20 @@ def _try_activate_fallback(self) -> bool:
# access for Codex providers.
try:
from agent.auxiliary_client import resolve_provider_client
fb_base_url_explicit = (fb.get("base_url") or "").strip() or None
fb_api_key_explicit = (fb.get("api_key") or "").strip()
if not fb_api_key_explicit:
fb_key_env = (fb.get("api_key_env") or "").strip()
if fb_key_env:
fb_api_key_explicit = os.getenv(fb_key_env, "").strip()
fb_api_key_explicit = fb_api_key_explicit or None
fb_client, _ = resolve_provider_client(
fb_provider, model=fb_model, raw_codex=True)
fb_provider,
model=fb_model,
raw_codex=True,
explicit_base_url=fb_base_url_explicit,
explicit_api_key=fb_api_key_explicit,
)
if fb_client is None:
logging.warning(
"Fallback to %s failed: provider not configured",
Expand Down