You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related: #48919 (competing fix for the same issue #48912, different mechanism — it re-resolves the session key for the queued follow-up re-entry in _notify_long_running, whereas this PR threads the caller-resolved session_key into _prepare_inbound_message_text at the buffer-write site). Both build on the per-session native-image-buffer isolation introduced by merged #18202. Same goal, distinct code sites — not a duplicate; maintainers should pick the preferred mechanism (or combine both, since #48919 covers the queued-followup branch and this covers the direct write site).
Acknowledged: noted competing PR(s) #48919, #48912, #18202, #48919. My approach differs and is complementary, not mutually exclusive. Open to consolidating if reviewers prefer one direction.
Merged via PR #57648. Your commit was cherry-picked onto current main with your authorship preserved in git log (rebase-merge). We added a small follow-up on top reordering the queued-follow-up session-key resolution so it happens before the inbound-text prep buffers images. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/agentCore agent runtime: loop, agent_init, prompt builder, context-compression, responses endpointcomp/gatewayGateway runner, session dispatch, deliveryP2Medium — degraded but workaround existstool/visionVision analysis and image generationtype/bugSomething isn't working
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #48912
Validation
Review