fix(cli): default Windows subprocess text decoding - #48839
Closed
rylena wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Duplicate of #48838 — both PRs fix #47939 by monkeypatching |
tonydwb
approved these changes
Jun 19, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved — Windows subprocess text decoding fix.
- 2 files changed (+187/-0)
- Fixes default Windows subprocess text decoding
- No security concerns, no debug artifacts
Reviewed by Hermes Agent
Contributor
Author
|
Closing this as a duplicate of #48838 for the same Windows subprocess text-decoding fix, so review effort stays concentrated on the earlier open PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoding/errorschoices.text=True,universal_newlines=True, positionaluniversal_newlines, and encoding/errors-triggered text mode.Closes #47939
Verification
scripts/run_tests.sh tests/hermes_cli/test_windows_subprocess_text_decoding.py✅ (6 passed)python scripts/check-windows-footguns.py --all✅Codex was attempted first for repo-safe implementation, but it hit the known hidden-workspace / CA-bundle sandbox failures and could not inspect the checkout, so Hermes handled the fallback implementation and verification directly.