Skip to content

fix(update): approve npm install scripts used by update - #48816

Open
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix-43997-npm-allow-scripts
Open

LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix-43997-npm-allow-scripts

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

Summary

  • add pinned allowScripts entries for the packages Hermes update currently installs
  • cover both the repo-root --workspaces=false install and the ui-tui/web workspace install path
  • keep the policy limited to the exact versions currently exercised on main

Testing

  • npm install --dry-run --no-fund --no-audit --progress=false --workspaces=false
  • npm install --dry-run --no-fund --no-audit --progress=false --workspace ui-tui --workspace web
  • git diff --check

Closes #43997

@LeonSGP43
LeonSGP43 requested a review from a team June 19, 2026 04:04
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard labels Jun 19, 2026
@teknium1

Copy link
Copy Markdown
Collaborator

Thanks for the focused update-path policy change. Current main still runs the same scoped npm installs—root at hermes_cli/main.py:8245-8258, then ui-tui and web at hermes_cli/main.py:8266-8275—and the root manifest still has no allowScripts key (package.json:35-45). The four pinned entries match current lockfile install-script packages.

The change remains narrowly aligned with the update path because desktop is explicitly skipped by that flow (hermes_cli/main.py:8233-8239). Related PR #51471 overlaps these four entries and extends the policy to desktop packages; that is a maintainer policy-selection question, not a defect in this scoped patch.

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform area/install-update Installer, updater, packaging, wheels, doctor labels Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/install-update Installer, updater, packaging, wheels, doctor comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm 11 allowScripts warnings during Hermes update

3 participants