fix: display active model in /status command - #48804
Closed
GautamKumarOffical wants to merge 1 commit into
Closed
Conversation
The /status command was reading the model from the config file, but when users switch models using /model without --global, the model wasn't being persisted to the config. This caused /status to show the old model. Now /status checks _session_model_overrides first (where /model stores session-specific switches), then falls back to the session database, and finally to the config file. Closes NousResearch#48715
Collaborator
|
Duplicate of #11079 — both fix #48715 by making |
tonydwb
approved these changes
Jun 19, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
- 1 file changed, +7/-0 lines — displays active model in status command output
- Small, targeted fix; no security or test concerns
Reviewed by Hermes Agent
Author
|
Closing — marked duplicate of #11079. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/statuscommand was reading the model from the config file, but when users switch models using/modelwithout--global, the model wasn't being persisted to the config. This caused/statusto show the old model instead of the active one.Now
/statuschecks_session_model_overridesfirst (where/modelstores session-specific switches), then falls back to the session database, and finally to the config file.Changes
_session_model_overridesin_handle_status_commandTest plan
/model deepseek/deepseek-v4-proto switch model/statusto verify the new model is displayed/model --global openai/gpt-4oto switch globally/statusto verify the global model is displayedCloses #48715