fix(desktop): expose full model titles - #48767
Conversation
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Fix to expose full model titles in the desktop UI. 181 additions across 4 files, addressing a UX clarity issue where truncated model names could cause confusion. Well-scoped change. No security or quality concerns.
Reviewed by Hermes Agent
teknium1
left a comment
There was a problem hiding this comment.
Thanks for the focused regression coverage. The underlying fallback and submenu gaps are still present, but current main has moved to the themed Tip convention.
Problems
- Current
mainalready wraps top-level statusbar controls inTip(apps/desktop/src/app/shell/statusbar-controls.tsx:119-128,177-218) afterda73223f4; the PR's nativetitleassertions no longer describe that UI contract. - The actionable remaining model gap is the fallback at
apps/desktop/src/app/chat/composer/model-pill.tsx:76-89, whose tooltip still says only “Open model picker” rather than the available full provider/model value. - Generated submenu controls still discard
menuItem.titleatapps/desktop/src/app/shell/statusbar-controls.tsx:142-170, despite current producers setting it inuse-statusbar-items.tsx:321-338.
Suggested changes
- Adapt the model fallback and submenu passthrough onto current
main, preservingTipfor top-level controls and updating tests for tooltip behavior rather than nativetitleattributes.
Automated hermes-sweeper review.
| disabled={disabled} | ||
| onClick={() => setModelPickerOpen(true)} | ||
| title={copy.openModelPicker} | ||
| title={title} |
There was a problem hiding this comment.
Current main uses the themed Tip component rather than native title attributes. Please adapt this fallback onto the current Tip wrapper while preserving the action-oriented aria-label; the fallback Tip is the remaining path that still omits the full model value.
| @@ -125,13 +127,15 @@ function StatusbarItemView({ item, navigate }: { item: StatusbarItem; navigate: | |||
|
|
|||
There was a problem hiding this comment.
Top-level statusbar controls are now covered by Tip on current main. Keep the useful menu-child passthrough, but update the test expectations so they validate the current themed-tooltip contract for the existing top-level branches.
Summary
Fixes #47975
Tests
Review