Skip to content

fix(npm): lock react-simple-icons to 13.11.1 - #48657

Merged
ethernet8023 merged 1 commit into
mainfrom
hermes-icons
Jun 18, 2026
Merged

fix(npm): lock react-simple-icons to 13.11.1#48657
ethernet8023 merged 1 commit into
mainfrom
hermes-icons

Conversation

@ethernet8023

Copy link
Copy Markdown
Collaborator

What does this PR do?

suppress annoying message about engines that's completely benign but people seem to complain

Related Issue

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • locks react-simple-icons to a versions before the node 26 min req was added

How to Test

  1. npm ci
  2. no warning about EBADENGINE->

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

suppress annoying message about engines that's completely benign but
people seem to complain
@ethernet8023
ethernet8023 requested a review from a team June 18, 2026 21:42
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes-icons vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 11033 on HEAD, 11033 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 5781 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@ethernet8023
ethernet8023 enabled auto-merge June 18, 2026 21:43
@ethernet8023
ethernet8023 merged commit cbe44bf into main Jun 18, 2026
34 checks passed
@ethernet8023
ethernet8023 deleted the hermes-icons branch June 18, 2026 21:47
@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change comp/tui Terminal UI (ui-tui/ + tui_gateway/) P3 Low — cosmetic, nice to have labels Jun 18, 2026
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
fix(npm): lock react-simple-icons to 13.11.1
habarmc1223-sudo pushed a commit to habarmc1223-sudo/hermes-agent-fluxmem that referenced this pull request Jul 8, 2026
fix(npm): lock react-simple-icons to 13.11.1
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
fix(npm): lock react-simple-icons to 13.11.1
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
fix(npm): lock react-simple-icons to 13.11.1
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
fix(npm): lock react-simple-icons to 13.11.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tui Terminal UI (ui-tui/ + tui_gateway/) P3 Low — cosmetic, nice to have type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants