fix(qqbot): accept dm chat_type in approval authorization - #48600
Open
warm-stone wants to merge 1 commit into
Open
fix(qqbot): accept dm chat_type in approval authorization#48600warm-stone wants to merge 1 commit into
warm-stone wants to merge 1 commit into
Conversation
The gateway normalizes every platform private (C2C) chat to chat_type "dm" in session keys (e.g. agent:main:qqbot:dm:<openid>), via build_source(chat_type="dm") in _handle_c2c_message and the shared base adapter. However _is_authorized_interaction_for_session only matched the QQ-specific term "c2c", so every private-chat approval/update button click fell through to return False and was rejected as unauthorized. Symptom: clicking Allow once / Allow always / Deny in a QQ private chat logged "Rejected unauthorized approval click" and never unblocked the agent, so the gated terminal command timed out as BLOCKED. Telegram DMs were unaffected (their authorizer normalizes chat_type to "dm"). Fix: treat dm/private/direct as aliases of c2c in the private-chat authorization branch, matching the gateway-normalized session key. Added unit tests covering dm/c2c acceptance, wrong-operator and group-scene rejection, and malformed session keys.
Collaborator
Contributor
|
Thanks for the focused regression fix. Current The proposed condition preserves the existing exact owner comparison, and the regression tests cover the previously rejected DM-shaped session key. This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gateway normalizes every platform private (C2C) chat to chat_type "dm" in session keys (e.g. agent:main:qqbot:dm:), via build_source(chat_type="dm") in _handle_c2c_message and the shared base adapter. However _is_authorized_interaction_for_session only matched the QQ-specific term "c2c", so every private-chat approval/update button click fell through to return False and was rejected as unauthorized.
Symptom: clicking Allow once / Allow always / Deny in a QQ private chat logged "Rejected unauthorized approval click" and never unblocked the agent, so the gated terminal command timed out as BLOCKED. Telegram DMs were unaffected (their authorizer normalizes chat_type to "dm").
Fix: treat dm/private/direct as aliases of c2c in the private-chat authorization branch, matching the gateway-normalized session key. Added unit tests covering dm/c2c acceptance, wrong-operator and group-scene rejection, and malformed session keys.
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs