Conversation
Collaborator
|
Thanks for the precise documentation correction. Current Automated hermes-sweeper review. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
mirror_to_session()ingateway/mirror.pydocuments:But the implementation only calls
_append_to_sqlite(session_id, mirror_msg)-there is no JSONL write. The docstring promises a write path that does not
exist, which misleads anyone reading or debugging the mirror flow into looking
for a JSONL transcript that never gets written.
This is intentional behavior - sessions are stored in SQLite
(
SessionDB/hermes_state.py), and the per-sessiontranscript.jsonlis alegacy format that the codebase only cleans up, never writes here. So the
code is correct and the docstring is wrong.
Fix
Update the docstring to describe what the function actually does:
Docstring-only change; no behavior change. The SQLite-only write path is left
exactly as-is.