fix(nix): refresh npmDepsHash after the Electron 40.10.2 pin (#47792) - #48457
Merged
Conversation
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-attribute |
2 |
First entries
run_agent.py:2941: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
✅ Fixed issues (1):
| Rule | Count |
|---|---|
invalid-assignment |
1 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`
Unchanged: 5768 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
PR #47792 pinned Electron to an exact 40.10.2 and regenerated the root package-lock.json (dropping @electron/get@5 + @electron-internal/extract-zip, restoring @electron/get@2 + extract-zip@2 + yauzl), but did not refresh the shared npmDepsHash in nix/lib.nix. The hash still described the previous 40.10.3 lockfile, so npmConfigHook fails on every Nix build with "npmDepsHash is out of date" for hermes-tui / hermes-web / hermes-desktop. Regenerate the single shared hash to match the current lockfile. Verified with fetchNpmDeps (authoritative, not prefetch-npm-deps): nix build .#tui.npmDeps -> builds clean nix build .#tui -> Validating consistency -> Installing dependencies -> Finished npmConfigHook (no hash error)
alt-glitch
force-pushed
the
fix/refresh-npm-deps-hash
branch
from
June 18, 2026 14:55
e968567 to
184dd24
Compare
alt-glitch
enabled auto-merge (squash)
June 18, 2026 14:55
This was referenced Jun 19, 2026
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…earch#47792) (NousResearch#48457) PR NousResearch#47792 pinned Electron to an exact 40.10.2 and regenerated the root package-lock.json (dropping @electron/get@5 + @electron-internal/extract-zip, restoring @electron/get@2 + extract-zip@2 + yauzl), but did not refresh the shared npmDepsHash in nix/lib.nix. The hash still described the previous 40.10.3 lockfile, so npmConfigHook fails on every Nix build with "npmDepsHash is out of date" for hermes-tui / hermes-web / hermes-desktop. Regenerate the single shared hash to match the current lockfile. Verified with fetchNpmDeps (authoritative, not prefetch-npm-deps): nix build .#tui.npmDeps -> builds clean nix build .#tui -> Validating consistency -> Installing dependencies -> Finished npmConfigHook (no hash error)
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…earch#47792) (NousResearch#48457) PR NousResearch#47792 pinned Electron to an exact 40.10.2 and regenerated the root package-lock.json (dropping @electron/get@5 + @electron-internal/extract-zip, restoring @electron/get@2 + extract-zip@2 + yauzl), but did not refresh the shared npmDepsHash in nix/lib.nix. The hash still described the previous 40.10.3 lockfile, so npmConfigHook fails on every Nix build with "npmDepsHash is out of date" for hermes-tui / hermes-web / hermes-desktop. Regenerate the single shared hash to match the current lockfile. Verified with fetchNpmDeps (authoritative, not prefetch-npm-deps): nix build .#tui.npmDeps -> builds clean nix build .#tui -> Validating consistency -> Installing dependencies -> Finished npmConfigHook (no hash error)
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…earch#47792) (NousResearch#48457) PR NousResearch#47792 pinned Electron to an exact 40.10.2 and regenerated the root package-lock.json (dropping @electron/get@5 + @electron-internal/extract-zip, restoring @electron/get@2 + extract-zip@2 + yauzl), but did not refresh the shared npmDepsHash in nix/lib.nix. The hash still described the previous 40.10.3 lockfile, so npmConfigHook fails on every Nix build with "npmDepsHash is out of date" for hermes-tui / hermes-web / hermes-desktop. Regenerate the single shared hash to match the current lockfile. Verified with fetchNpmDeps (authoritative, not prefetch-npm-deps): nix build .#tui.npmDeps -> builds clean nix build .#tui -> Validating consistency -> Installing dependencies -> Finished npmConfigHook (no hash error)
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…earch#47792) (NousResearch#48457) PR NousResearch#47792 pinned Electron to an exact 40.10.2 and regenerated the root package-lock.json (dropping @electron/get@5 + @electron-internal/extract-zip, restoring @electron/get@2 + extract-zip@2 + yauzl), but did not refresh the shared npmDepsHash in nix/lib.nix. The hash still described the previous 40.10.3 lockfile, so npmConfigHook fails on every Nix build with "npmDepsHash is out of date" for hermes-tui / hermes-web / hermes-desktop. Regenerate the single shared hash to match the current lockfile. Verified with fetchNpmDeps (authoritative, not prefetch-npm-deps): nix build .#tui.npmDeps -> builds clean nix build .#tui -> Validating consistency -> Installing dependencies -> Finished npmConfigHook (no hash error)
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…earch#47792) (NousResearch#48457) PR NousResearch#47792 pinned Electron to an exact 40.10.2 and regenerated the root package-lock.json (dropping @electron/get@5 + @electron-internal/extract-zip, restoring @electron/get@2 + extract-zip@2 + yauzl), but did not refresh the shared npmDepsHash in nix/lib.nix. The hash still described the previous 40.10.3 lockfile, so npmConfigHook fails on every Nix build with "npmDepsHash is out of date" for hermes-tui / hermes-web / hermes-desktop. Regenerate the single shared hash to match the current lockfile. Verified with fetchNpmDeps (authoritative, not prefetch-npm-deps): nix build .#tui.npmDeps -> builds clean nix build .#tui -> Validating consistency -> Installing dependencies -> Finished npmConfigHook (no hash error)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every Nix build of the npm workspaces currently fails with:
Root cause: PR #47792 ("pin Electron below the broken native extract-zip install") pinned Electron to an exact
40.10.2and regenerated the rootpackage-lock.json— dropping@electron/get@5+@electron-internal/extract-zip, restoring@electron/get@2+extract-zip@2+yauzl. That PR touchedapps/desktop/package.json,package.json,package-lock.json, and a test, but notnix/lib.nix. The single sharednpmDepsHashstill described the old40.10.3lockfile, sonpmConfigHook's consistency check fails onhermes-tui,hermes-web, andhermes-desktop.This is reproducible on current
main(HEAD at branch point), not just stale checkouts.Fix
Regenerate the one shared hash in
nix/lib.nix:Computed via
fetchNpmDeps(authoritative —prefetch-npm-depscan disagree, per the notes inlib.nix).Test plan
Follow-up (not in this PR)
The
nix-lockfile-fixautomation should have caught this. See open PR #41004 ("Update nix-lockfile-fix.yml to stage nix/lib.nix") — the auto-refresh workflow apparently doesn't stagenix/lib.nix, which is exactly why a lockfile-changing PR (#47792) could land without the hash following it. Worth landing that to prevent recurrence.