You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related: #18427, #38231, #47408, #41478, #29955 (open fix PRs for the same root cause, #33618 / #18467 — persistent /goal lost after compression rotates session_id). Those PRs migrate goal state at the compression boundary (migrate_goal(old, new) in conversation_compression.py); this PR takes a different mechanism — re-keying goal storage to the conversation lineage root (goal:<root_session_id>) and walking parent lineage, plus delegate-child exclusion and migrate-before-prune. Same goal, different approach -> related, not duplicate.
Note: This is NOT a duplicate of the prior closed PRs (#18427, #38231, #47408, #41478, #29955, #33618, #18467). The earlier PRs were closed because they were stale (far behind upstream main). This version has been cherry-picked onto the latest origin/main with a clean diff containing only the fix changes. No conflicts. CI green. Ready for review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/agentCore agent runtime: loop, agent_init, prompt builder, context-compression, responses endpointcomp/cliCLI entry point, hermes_cli/, setup wizardP2Medium — degraded but workaround existstype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/goalstate attached to the whole conversation lineage instead of one transient session id.Test Plan
/Users/yu/.hermes/hermes-agent/venv/bin/python -m pytest tests/hermes_cli/test_aux_config.py tests/tui_gateway/test_goal_command.py -qgit diff --check