fix(cli): make refresh_interval configurable, default to 0 (disabled) - #48312
Closed
OYLFLMH wants to merge 1 commit into
Closed
fix(cli): make refresh_interval configurable, default to 0 (disabled)#48312OYLFLMH wants to merge 1 commit into
OYLFLMH wants to merge 1 commit into
Conversation
Commit 6724daa added refresh_interval=1.0 to keep the idle clock ticking, but unconditional 1 Hz redraws in non-fullscreen prompt_toolkit mode cause terminal emulators (Xshell, iTerm2, Windows Terminal) to auto-scroll to the bottom on every tick — breaking scroll-up to read history. Drive it from display.cli_refresh_interval (0 = disabled, the default) so users who want the ticking clock can opt in without affecting everyone. Fixes: NousResearch#48309 Related: 6724daa, 8972a15
Contributor
Author
|
Closing — the feature was implemented upstream in v0.17.0 (commit 2bd1977) with the same config key ( The only difference is the default value: this PR used Both approaches are valid — upstream's choice keeps the existing behavior as default while allowing opt-out, which is the more conservative migration path. No further action needed on this PR. |
xyshanren
pushed a commit
to xyshanren/hermes-agent-cn
that referenced
this pull request
Jun 25, 2026
Follow-up to the salvaged NousResearch#48312 — adds the config-default test (ported from NousResearch#48319) and the AUTHOR_MAP entry for the cherry-picked commit.
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
Follow-up to the salvaged NousResearch#48312 — adds the config-default test (ported from NousResearch#48319) and the AUTHOR_MAP entry for the cherry-picked commit.
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
Follow-up to the salvaged NousResearch#48312 — adds the config-default test (ported from NousResearch#48319) and the AUTHOR_MAP entry for the cherry-picked commit.
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
Follow-up to the salvaged NousResearch#48312 — adds the config-default test (ported from NousResearch#48319) and the AUTHOR_MAP entry for the cherry-picked commit.
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
Follow-up to the salvaged NousResearch#48312 — adds the config-default test (ported from NousResearch#48319) and the AUTHOR_MAP entry for the cherry-picked commit.
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
Follow-up to the salvaged NousResearch#48312 — adds the config-default test (ported from NousResearch#48319) and the AUTHOR_MAP entry for the cherry-picked commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Commit
6724daa2c("fix: keep CLI idle timer ticking #45592") addedrefresh_interval=1.0to the prompt_toolkitApplicationin non-fullscreen classic CLI mode. This causes a full UI redraw every second during idle time.Terminal emulators with "auto-scroll on output" (Xshell, iTerm2, Windows Terminal, etc.) interpret the ANSI output from each redraw as new content and auto-scroll the viewport to the bottom — even when the user has manually scrolled up to read conversation history.
Fixes: #48309
Root Cause
The original code explicitly warned against this (cli.py ~L12927 before
6724daa2c):Change
Drive
refresh_intervalfromdisplay.cli_refresh_intervalinconfig.yaml, defaulting to0(disabled — the pre-0.15.2 behavior). Users who want the idle clock to keep ticking can set it to1.0(or any positive value).cli.py (1 line change)
hermes_cli/config.py (1 key added)
Testing
python3 -m py_compile cli.py hermes_cli/config.py— passesscripts/run_tests.sh tests/cli/— 78 files, 924 tests, 0 failures