fix(desktop): refresh sidebar after auto-title - #48136
Closed
tt-a1i wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the focused Desktop/TUI investigation. An automated hermes-sweeper review found the reported sidebar-refresh behavior is already implemented on current
Thank you for identifying the event-and-row-reconciliation path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_session_title()confirms the title was storedFixes #47926. Related to #44810, but that backend-only PR emits
session.info; the current Desktop sidebar does not patch title rows from that event, and_session_info()does not carry the title.Testing
$HOME/.hermes/hermes-agent/venv/bin/python -m pytest tests/agent/test_title_generator.py$HOME/.hermes/hermes-agent/venv/bin/python -m pytest tests/agent/test_title_generator.py tests/test_tui_gateway_server.py -k "title_callback or auto_title or session_title"npm --workspace apps/desktop run typechecknpm --workspace apps/desktop run test:ui -- src/store/session.test.ts -t applySessionTitleUpdatenpm --workspace apps/desktop exec eslint -- --quiet src/store/session.ts src/store/session.test.ts src/app/session/hooks/use-message-stream.ts src/lib/chat-messages.tsgit diff --checkNote: running the full
src/store/session.test.tsfile in this local jsdom setup still fails in pre-existing workspaceCwdForNewSession tests becausewindow.localStorageis unavailable; the newapplySessionTitleUpdatefocused tests pass.