Skip to content

fix: honor model request overrides at agent startup - #48113

Closed
supplefrog wants to merge 1 commit into
NousResearch:mainfrom
supplefrog:fix/model-request-overrides-extra-body-20203
Closed

fix: honor model request overrides at agent startup#48113
supplefrog wants to merge 1 commit into
NousResearch:mainfrom
supplefrog:fix/model-request-overrides-extra-body-20203

Conversation

@supplefrog

Copy link
Copy Markdown
Contributor

Summary

  • Load optional model.request_overrides from config.yaml during agent startup.
  • Merge global request overrides into AIAgent.request_overrides without clobbering explicit per-turn overrides.
  • Reuse the existing extra_body merge behavior so provider-native fields like OpenAI Responses text.verbosity can be configured without local source patches.

Refs #20203

Test Plan

  • python -m pytest tests/agent/test_custom_provider_extra_body.py tests/run_agent/test_run_agent_codex_responses.py -q -o 'addopts=' — 83 passed, 1 warning

Notes

  • Explicit per-turn request overrides still win over global model.request_overrides.
  • This is intentionally a low-level escape hatch for provider-native request body fields that Hermes has not promoted to first-class config yet.

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint area/config Config system, migrations, profiles labels Jun 17, 2026
@supplefrog

Copy link
Copy Markdown
Contributor Author

Closing because the first-class implementations for #20203 now cover the supported path directly. #29574 currently includes the provider capability boundary, nested text merge, validation, and gateway cache invalidation.

The generic model.request_overrides startup propagation may still be useful independently, but it should have its own focused issue rather than compete as an indirect solution to #20203.

@supplefrog supplefrog closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants