fix: honor model request overrides at agent startup - #48113
Closed
supplefrog wants to merge 1 commit into
Closed
Conversation
1 task
Contributor
Author
|
Closing because the first-class implementations for #20203 now cover the supported path directly. #29574 currently includes the provider capability boundary, nested The generic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model.request_overridesfromconfig.yamlduring agent startup.AIAgent.request_overrideswithout clobbering explicit per-turn overrides.extra_bodymerge behavior so provider-native fields like OpenAI Responsestext.verbositycan be configured without local source patches.Refs #20203
Test Plan
python -m pytest tests/agent/test_custom_provider_extra_body.py tests/run_agent/test_run_agent_codex_responses.py -q -o 'addopts='— 83 passed, 1 warningNotes
model.request_overrides.