You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#48013. Removed the byte-size comparison that discarded valid dimension-reduced resizes of PNG images. The _resize_image_for_vision function already handles dimension reduction; the caller should trust its output.
Duplicate of #48035 — both PRs fix #48013 in agent/conversation_compression.py by relaxing the same byte-growth rejection in _shrink_data_url (len(resized) >= len(url)) so a pixel-correct downscale is accepted even when the re-encoded PNG grows in bytes. #48035 (filed earlier, ~20:33Z) is the more complete version of the same approach — it tracks which constraint triggered the shrink and adds a regression test — so it's the canonical one. Marking this as duplicate.
Merged via #49140 (commit 990273d) — closes #48013. This was a duplicate fix for the same image-shrink brick. The merged PR keys the accept gate on the binding constraint (pixels vs bytes) against current main; the one-line change here predated the max_dimension plumbing from #45979 and would have reverted that cap parsing. Thanks for flagging the issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/agentCore agent runtime: loop, agent_init, prompt builder, context-compression, responses endpointduplicateThis issue or pull request already existsP2Medium — degraded but workaround existstool/visionVision analysis and image generationtype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48013. Removed the byte-size comparison that discarded valid dimension-reduced resizes of PNG images. The _resize_image_for_vision function already handles dimension reduction; the caller should trust its output.