Skip to content

fix(desktop): resolve Electron dist from workspace - #48028

Closed
rasitakyol wants to merge 1 commit into
NousResearch:mainfrom
rasitakyol:fix/desktop-electron-dist-workspace
Closed

fix(desktop): resolve Electron dist from workspace#48028
rasitakyol wants to merge 1 commit into
NousResearch:mainfrom
rasitakyol:fix/desktop-electron-dist-workspace

Conversation

@rasitakyol

Copy link
Copy Markdown
Contributor

Summary

  • point desktop electronDist at the Electron package installed under apps/desktop/node_modules
  • update desktop CLI and installer Electron-dist recovery paths to check the desktop workspace instead of the repo root
  • add a regression test locking electronDist to the workspace install location

Test Plan

  • uv run --extra dev pytest tests/test_desktop_electron_pin.py -q
  • ./venv/bin/python -m py_compile hermes_cli/main.py
  • bash -n scripts/install.sh
  • pwsh parser check for scripts/install.ps1 (if pwsh is available)
  • ./venv/bin/hermes desktop --build-only --cwd /Users/rasitakyol/Documents/GitHub/aicoolies-research

@rasitakyol
rasitakyol requested a review from a team June 17, 2026 20:10
@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard comp/tui Terminal UI (ui-tui/ + tui_gateway/) P2 Medium — degraded but workaround exists duplicate This issue or pull request already exists labels Jun 17, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #48003 — same fix (point desktop electronDist at the workspace-local apps/desktop/node_modules/electron/dist install, plus CLI/installer Electron-dist recovery paths), with an identical tests/test_desktop_electron_pin.py regression test. The changed files here are a subset of #48003 (the earliest open PR with this approach; #48012 was already marked a duplicate of it). All three target the build-after-update electronDist-resolution bug tracked in #47917.

@rasitakyol

Copy link
Copy Markdown
Contributor Author

Thanks for checking. Confirmed this is a duplicate of #48003 and #48003 is the broader/canonical fix for #47917. Closing this PR in favor of #48003.

@rasitakyol

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #48003.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/tui Terminal UI (ui-tui/ + tui_gateway/) duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants