fix: add -m/--model and --provider to root hermes parser - #4801
Closed
iRonin wants to merge 2 commits into
Closed
Conversation
iRonin
force-pushed
the
fix/root-model-flag
branch
3 times, most recently
from
April 4, 2026 22:00
e7f5bd6 to
314c6ed
Compare
hermes -c "session name" -m anthropic/claude-sonnet-4-6 now works. Previously -m was only on 'hermes chat', so the shorthand root-level -c flag couldn't be combined with a model override. Also stop stomping args.model/provider with None in the root→chat passthrough — the values from the root parser are now preserved.
iRonin
force-pushed
the
fix/root-model-flag
branch
from
April 11, 2026 20:37
5e8bada to
517212c
Compare
iRonin
added a commit
to iRonin/hermes-agent-nous
that referenced
this pull request
Apr 12, 2026
Contributor
|
Thanks for the contribution, @iRonin! This is an automated hermes-sweeper review. The fix proposed here is already on
Your PR was on the right track and likely informed the eventual fix. Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root
hermesparser supports-c/--continueand-r/--resumeas shortcuts to launch chat without typinghermes chat. However-m/--modeland--providerwere only defined on thehermes chatsubparser, so combining them didn't work:This adds
-m/--modeland--providerto the root parser and stops the root→chat passthrough from overwriting them withNone.Now works: