fix(mcp): don't trigger circuit breaker on business errors (#47851) - #47955
Closed
kyssta-exe wants to merge 1 commit into
Closed
fix(mcp): don't trigger circuit breaker on business errors (#47851)#47955kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
Collaborator
|
Duplicate of #40951 — same fix for the MCP circuit-breaker-on-business-errors bug (issue #47851 / canonical #11113). This adds a _business_error flag and gates the breaker bump on it; #40951 (opened 2026-06-07) is the earliest open PR taking this approach, and #47898 / #47918 already track to it. Marking duplicate of #40951; related to issue #47851. Maintainers can pick the preferred implementation. |
Contributor
Author
|
Stale — 26-27 days without merge activity. |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47851. Add a _business_error flag to MCP tool results that come from isError=true responses, so the circuit breaker only bumps the error count for actual server failures, not business-logic errors returned by the tool.